Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go1.19] kubekins/krte: Build go-canary variant using go1.19rc2 #26860

Merged
merged 1 commit into from
Jul 20, 2022
Merged

[go1.19] kubekins/krte: Build go-canary variant using go1.19rc2 #26860

merged 1 commit into from
Jul 20, 2022

Conversation

dims
Copy link
Member

@dims dims commented Jul 20, 2022 •
edited
Loading

Part of kubernetes/release#2575.

For Golang pre-releases, the go-canary variant needs to be built ahead of the master variant to enable testing go canary presubmits for:
kubernetes/kubernetes#111254

/assign @saschagrunert @puerco @justaugustus
/cc https://github.com/orgs/kubernetes/teams/release-engineering

Signed-off-by: Davanum Srinivas [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 20, 2022
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 20, 2022
@dims
Copy link
Member Author

dims commented Jul 20, 2022

/assign @justaugustus @saschagrunert @puerco @palnabarun

@puerco
Copy link
Member

puerco commented Jul 20, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2022
@palnabarun
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, palnabarun, puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 66e8b57 into kubernetes:master Jul 20, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@puerco puerco

@palnabarun palnabarun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
4 participants
@dims @puerco @palnabarun @k8s-ci-robot