Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] releng: Remove configs for k8s-beta jobs / add k8s-stable4 variants #26028

Closed
wants to merge 1 commit into from

Conversation

justaugustus
Copy link
Member

(Continuation of #26015.)

For years, we've had issues with the k8s-beta generic version
marker.

There are a few scenarios...

During the dev cycle:

  • beta should not exist, but actually points to the previous release

After a beta release:

  • beta should exist, but:
    1. no one really updated this manually
    2. the branch cuts and job creation happens at the RC stage

After an RC release (branch cut):

  • beta should have already existed
  • beta represents the RC version after branch job creation

After an official release:

  • beta should not exist, but actually points to the previous release

None of these scenarios are acceptable, so it's time to remove this
marker. Generated jobs that reference beta in their name have
already been using version-specific markers for multiple releases, so
this has minimal impact.

Here we instead add a k8s-stable4 marker, to provide a version
marker for a release branch that is in maintenance mode/soon-to-be
EOL-ed.

Adding a marker at the end of the set means we no longer have to
consider moving the k8s-beta marker during a release cycle.

Signed-off-by: Stephen Augustus [email protected]

/assign @puerco @Verolop @palnabarun
cc: @kubernetes/release-engineering

For years, we've had issues with the `k8s-beta` generic version
marker.

There are a few scenarios...

During the dev cycle:
- beta should not exist, but actually points to the previous release

After a beta release:
- beta should exist, but:
  1. no one really updated this manually
  2. the branch cuts and job creation happens at the RC stage

After an RC release (branch cut):
- beta should have already existed
- beta represents the RC version after branch job creation

After an official release:
- beta should not exist, but actually points to the previous release

None of these scenarios are acceptable, so it's time to remove this
marker. Generated jobs that reference `beta` in their name have
already been using version-specific markers for multiple releases, so
this has minimal impact.

Here we instead add a `k8s-stable4` marker, to provide a version
marker for a release branch that is in maintenance mode/soon-to-be
EOL-ed.

Adding a marker at the end of the set means we no longer have to
consider moving the `k8s-beta` marker during a release cycle.

Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 20, 2022
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider labels Apr 20, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justaugustus
To complete the pull request process, please assign andrewsykim after the PR has been reviewed.
You can assign the PR to them by writing /assign @andrewsykim in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 20, 2022
@justaugustus
Copy link
Member Author

/hold this still needs job regeneration and we should land the release branch jobs first

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2022
@k8s-ci-robot
Copy link
Contributor

@justaugustus: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-unit-test 6be11fb link true /test pull-test-infra-unit-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

@justaugustus: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2022
@justaugustus
Copy link
Member Author

We should resurrect this at some point, but for now:
/close

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Closed this PR.

In response to this:

We should resurrect this at some point, but for now:
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants