-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump kubebuilder-presubmits to use go 1.18 #25775
Conversation
--- Kubebuilder's master branch is introducing support for Golang 1.18 kubernetes-sigs/kubebuilder#2561
Welcome @AlmogBaku! |
Hi @AlmogBaku. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@camilamacedo86: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@camilamacedo86: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@camilamacedo86 can you please add lgtm? |
Hi @AlmogBaku, It is great that we have this PR open already. We will need it. I am looking to avoid breaking the ci and block other PRs. /hold |
/cc @camilamacedo86 |
/hold cancel We can move forward with it now |
/approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution 🥇
/approved |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlmogBaku, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@AlmogBaku: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description:
Kubebuilder's master branch is introducing support for Golang 1.18. This PR is changing the
pull-kubebuilder-test
pre-submit job to usegolang:1.18
image instead of the previous version.Motivation:
Kubebuilder Golang 1.18 Support PR kubernetes-sigs/kubebuilder#2561
Kubebuilder Golang 1.18 Issue kubernetes-sigs/kubebuilder#2559