fix: fetch error with depth 1

[cuyl]

clonerefs failed when BaseRef is ahead of the BaseSHA. it is common when rerunning the post jobs.

job config:

postsubmits:
  xxx/xxx:
  - name: post-job
    decorate: true
    clone_depth: 1
    skip_fetch_head: true
    skip_submodules: true

previous:

git fetch --depth 1 https://github.com/kubernetes/test-infra.git master
git checkout ed929b919c4b460353f867e055066e1ef8c522e2
fatal: reference is not a tree: ed929b919c4b460353f867e055066e1ef8c522e2
# Error: exit status 128

current:

git fetch --depth 1 https://github.com/kubernetes/test-infra.git ed929b919c4b460353f867e055066e1ef8c522e2
git checkout ed929b919c4b460353f867e055066e1ef8c522e2

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ YuChao Liang (d732484)

[k8s-ci-robot]

Welcome @cuyl!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @cuyl. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[cjwagner]

clonerefs failed when BaseRef is ahead of the BaseSHA.

Do you mean the other way around? If the BaseSHA that is being checked out is older than the HEAD of the BaseRef then the SHA would be available for checkout. I'm assuming you are referring to the BaseSHA somehow being ahead of the BaseRef HEAD and therefore not available after fetching the BaseRef.
Could you provide an example of when this could occur? I'm not sure what circumstances would allow for this.

it is common when rerunning the post jobs.

Rerunning a job creates a new job with an identical ProwJob spec. This includes the git refs so its unclear to me how rerunning a job would lead to this. If you could share a concrete example that would be helpful.

Thanks for the contribution! The error you are describing seems a bit unexpected though so I want to make sure we're fixing this in the most appropriate way.
/test all

[cjwagner]

Oh, I see. This is specifically a problem with postsubmits that set limited clone depth. In that case this makes sense, but I am a bit concerned that this could have unintended side effects.

@alvaroaleman @chaodaiG do you know if fetching the BaseRef rather than the BaseSHA is intentional/significant? I can't think of anything off the top of my head.

[cuyl]

I signed it

[k8s-ci-robot]

@cuyl: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alvaroaleman]

@alvaroaleman @chaodaiG do you know if fetching the BaseRef rather than the BaseSHA is intentional/significant? I can't think of anything off the top of my head.

I don't think so. We did a similar change for presubmits (motivated by some GitHub issues) which to my knowledge didn't cause any issues: #19928

/test all
/lgtm
/approve
/hold

[chaodaiG]

Fetching only to the commit that triggered the postsubmit, imo is even better than fetching latest HEAD, as there is no reason for a postsubmit job to fetch source code that is not meant to be used. So
/lgtm
/approve
/unhold

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, chaodaiG, cuyl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• prow/pod-utils/OWNERS [alvaroaleman,chaodaiG]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment