Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch kettle/triage service account keys to Workload Identity. #23678

Merged
merged 2 commits into from
Sep 21, 2021

Conversation

cjwagner
Copy link
Member

Once this merge I'll do the following:

  • For the metrics-kettle job I'll
    • bind the new KSA to the GSA
    • Switch the job to use the KSA rather than a GSA key.
  • For the Kettle deployments I'll
    • Create the KSA
    • Bind the KSA to the GSA
    • Manually deploy staging
    • Manually deploy prod

/hold
/assign @MushuEE @fejta

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/kettle area/prow/bump Updates to the k8s prow cluster sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 21, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2021
Copy link
Contributor

@MushuEE MushuEE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW we hope to have these moved off to k8s infra soon but lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, fejta, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cjwagner
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2b748fd into kubernetes:master Sep 21, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 21, 2021
@k8s-ci-robot
Copy link
Contributor

@cjwagner: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key test-infra-periodics.yaml using file config/jobs/kubernetes/test-infra/test-infra-periodics.yaml

In response to this:

Once this merge I'll do the following:

  • For the metrics-kettle job I'll
    • bind the new KSA to the GSA
    • Switch the job to use the KSA rather than a GSA key.
  • For the Kettle deployments I'll
    • Create the KSA
    • Bind the KSA to the GSA
    • Manually deploy staging
    • Manually deploy prod

/hold
/assign @MushuEE @fejta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/kettle area/prow/bump Updates to the k8s prow cluster cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants