Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releng(promo-tools): Bump images to v3.2.0 #23591

Merged
merged 1 commit into from
Sep 14, 2021
Merged

releng(promo-tools): Bump images to v3.2.0 #23591

merged 1 commit into from
Sep 14, 2021

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Sep 14, 2021 •
edited
Loading

Image bump for CIP release v3.2.0: kubernetes-sigs/promo-tools#426

Signed-off-by: Stephen Augustus [email protected]

/hold for release + image promotion
v3.2.0: https://github.com/kubernetes-sigs/k8s-container-image-promoter/releases/tag/v3.2.0
Image promotion PR: kubernetes/k8s.io#2720

(Will issue a separate PR for the test-infra Prow bump.)

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 14, 2021
@k8s-ci-robot k8s-ci-robot requested review from hh and puerco September 14, 2021 15:02
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 14, 2021
@justaugustus
Copy link
Member Author

/assign @cpanato @puerco @Verolop
cc: @kubernetes/release-engineering

@puerco
Copy link
Member

puerco commented Sep 14, 2021

/lgtm

1 similar comment
@Verolop
Copy link
Contributor

Verolop commented Sep 14, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 14, 2021
@justaugustus justaugustus mentioned this pull request Sep 14, 2021
Merged
cpanato
cpanato approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 14, 2021
@justaugustus
Copy link
Member Author

/hold cancel
v3.2.0: https://github.com/kubernetes-sigs/k8s-container-image-promoter/releases/tag/v3.2.0
Image promotion PR: kubernetes/k8s.io#2720

I think it now needs --confirm and drop --dry-run bellow?

@puerco -- Has been addressed for all jobs.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2021
@puerco
Copy link
Member

puerco commented Sep 14, 2021

Thank you!!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2021
cpanato
cpanato approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member Author

FYI @kubernetes/wg-k8s-infra

@k8s-ci-robot k8s-ci-robot merged commit 2222e05 into kubernetes:master Sep 14, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 14, 2021
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key container-image-promoter.yaml using file config/jobs/kubernetes/sig-release/cip/container-image-promoter.yaml
  • key releng-trusted.yaml using file config/jobs/kubernetes/wg-k8s-infra/trusted/releng/releng-trusted.yaml

In response to this:

Image bump for CIP release v3.2.0: kubernetes-sigs/promo-tools#426

Signed-off-by: Stephen Augustus [email protected]

/hold for release + image promotion
v3.2.0: https://github.com/kubernetes-sigs/k8s-container-image-promoter/releases/tag/v3.2.0
Image promotion PR: kubernetes/k8s.io#2720

(Will issue a separate PR for the test-infra Prow bump.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 14, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puerco puerco puerco requested changes

@cpanato cpanato cpanato approved these changes

@hh hh Awaiting requested review from hh

Assignees

@Verolop Verolop

@puerco puerco

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
5 participants
@justaugustus @puerco @Verolop @k8s-ci-robot @cpanato