Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ingress-nginx debian image generation #23478

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Sep 4, 2021

We are doing an attempt to migrate to Debian as stabilize some weird coredumps errors.

So we need to regenerate all images, from the base one to the final one.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 4, 2021
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Leave a comment

run_if_changed: 'images/nginx-debian/.*'
branches:
- ^main$
- ^dev-v1$
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this branch?

run_if_changed: 'images/modsecurity/.*'
branches:
- ^main$
- ^dev-v1$
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

run_if_changed: 'images/test-runner-debian/.*'
branches:
- ^main$
- ^dev-v1$
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

@rikatz
Copy link
Contributor Author

rikatz commented Sep 5, 2021

@tao12345666333 thanks for the review.

I've changed from dev-v1 to legacy on the cases that matters (old images that we still support) and in Debian case kept only dev-v1 as this is going to be somethng new :)

@ameukam
Copy link
Member

ameukam commented Sep 7, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 85fa4e1 into kubernetes:master Sep 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 7, 2021
@k8s-ci-robot
Copy link
Contributor

@rikatz: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8s-staging-ingress-nginx.yaml using file config/jobs/image-pushing/k8s-staging-ingress-nginx.yaml

In response to this:

We are doing an attempt to migrate to Debian as stabilize some weird coredumps errors.

So we need to regenerate all images, from the base one to the final one.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants