-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ingress-nginx debian image generation #23478
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Leave a comment
run_if_changed: 'images/nginx-debian/.*' | ||
branches: | ||
- ^main$ | ||
- ^dev-v1$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove this branch?
run_if_changed: 'images/modsecurity/.*' | ||
branches: | ||
- ^main$ | ||
- ^dev-v1$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
run_if_changed: 'images/test-runner-debian/.*' | ||
branches: | ||
- ^main$ | ||
- ^dev-v1$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
@tao12345666333 thanks for the review. I've changed from dev-v1 to legacy on the cases that matters (old images that we still support) and in Debian case kept only dev-v1 as this is going to be somethng new :) |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rikatz: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We are doing an attempt to migrate to Debian as stabilize some weird coredumps errors.
So we need to regenerate all images, from the base one to the final one.