Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sig-release jobs to use new ci-images location #22860

Closed

Conversation

jackfrancis
Copy link
Contributor

This PR updates the sig-release jobs that refer to gcr.io/kubernetes-ci-images to instead use the new gcr.io/k8s-staging-ci-images path.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 12, 2021
@jackfrancis
Copy link
Contributor Author

cc @chewong

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jackfrancis
To complete the pull request process, please assign cpanato after the PR has been reviewed.
You can assign the PR to them by writing /assign @cpanato in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 12, 2021
@jackfrancis
Copy link
Contributor Author

@spiffxp In the mad rush to investigate broken tests I suspected this change may help. But as the affecting change (#22840) originated in test-infra, this is probably not actually a valid change.

Can you confirm? If this is not relevant, I'll close the PR. (or feel free to close it yourself)

@spiffxp
Copy link
Member

spiffxp commented Jul 12, 2021

/close
Yeah these deprecated jobs are intentionally pushing to the deprecated locations, so I'm going to close this. Thanks for the effort though.

It looks like you got it sorted out in kubernetes-sigs/cluster-api-provider-azure#1512, I sketched out my guess at root cause in #22840 (comment)

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closed this PR.

In response to this:

/close
Yeah these deprecated jobs are intentionally pushing to the deprecated locations, so I'm going to close this. Thanks for the effort though.

It looks like you got it sorted out in kubernetes-sigs/cluster-api-provider-azure#1512, I sketched out my guess at root cause in #22840 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jackfrancis jackfrancis deleted the capz-k8s-staging-ci-images branch July 12, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants