Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releng: Build job fixups #22790

Merged
merged 3 commits into from
Jul 7, 2021
Merged

releng: Build job fixups #22790

merged 3 commits into from
Jul 7, 2021

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Jul 3, 2021 •
edited
Loading

Part of kubernetes/release#1711 and kubernetes/k8s.io#1569.

  • Shift release branches to the correct extra version markers
  • Use krel ci-build for ci-kubernetes-build-fast job
  • Remove EOL 1.18 build jobs

There are still references to clean up, but I'd like to take them as a follow-up: https://cs.k8s.io/?q=kubernetes-release-dev&i=nope&files=&excludeFiles=&repos=

/assign @puerco @cpanato @saschagrunert @spiffxp
cc: @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 3, 2021
@k8s-ci-robot k8s-ci-robot requested review from cpanato and xmudrii July 3, 2021 21:01
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 3, 2021
xmudrii
xmudrii approved these changes Jul 3, 2021
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold
if anyone else wants to take a look

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2021
@xmudrii
Copy link
Member

xmudrii commented Jul 3, 2021

/retest

@justaugustus justaugustus mentioned this pull request Jul 3, 2021
Merged
@justaugustus
Copy link
Member Author

Accompanying k/k PR: kubernetes/kubernetes#103461
(merge order is unimportant)

@justaugustus
Copy link
Member Author

/test pull-test-infra-gubernator

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2021
cpanato
cpanato approved these changes Jul 5, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2021
@cpanato
Copy link
Member

cpanato commented Jul 5, 2021

/retest

@xmudrii xmudrii mentioned this pull request Jul 6, 2021
Merged
@justaugustus
releng: Remove EOL 1.18 build jobs
c461c8b 
Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 7, 2021
@justaugustus
Copy link
Member Author

/hold cancel
The removal of the config/jobs/kubernetes/sig-release/release-branch-jobs/1.18.yaml led to some odd failures that I don't have time to debug at the moment:

I've restored the file in c461c8b and instead removed the 1.18 build jobs.

@kubernetes/release-managers -- needs re-lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2021
@puerco
Copy link
Member

puerco commented Jul 7, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2021
@k8s-ci-robot
Copy link
Contributor

@justaugustus: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit a1086c9 into kubernetes:master Jul 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 7, 2021
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubernetes-builds.yaml using file config/jobs/kubernetes/sig-release/kubernetes-builds.yaml
  • key 1.18.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.18.yaml
  • key 1.19.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.19.yaml
  • key 1.20.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.20.yaml
  • key 1.21.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.21.yaml

In response to this:

Part of kubernetes/release#1711 and kubernetes/k8s.io#1569.

  • Shift release branches to the correct extra version markers
  • Use krel ci-build for ci-kubernetes-build-fast job
  • Remove EOL 1.18 build jobs

There are still references to clean up, but I'd like to take them as a follow-up: https://cs.k8s.io/?q=kubernetes-release-dev&i=nope&files=&excludeFiles=&repos=

/assign @puerco @cpanato @saschagrunert @spiffxp
cc: @kubernetes/release-engineering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp mentioned this pull request Jul 15, 2021
Closed
liggitt
liggitt reviewed Jul 15, 2021
View reviewed changes
config/jobs/kubernetes/sig-release/release-branch-jobs/1.21.yaml
@@ -217,7 +217,7 @@ periodics:
- --scenario=kubernetes_build
- --
- --allow-dup
- --extra-version-markers=k8s-beta
Copy link
Member

@liggitt liggitt Jul 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean that all CI jobs using the k8s-beta marker (https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-cloud-provider/gcp/upgrade-gce.yaml#L134-L135) need to change to k8s-stable1?

xref kubernetes/kubernetes#103697

@spiffxp spiffxp mentioned this pull request Jul 15, 2021
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@cpanato cpanato cpanato approved these changes

@xmudrii xmudrii xmudrii approved these changes

Assignees

@spiffxp spiffxp

@saschagrunert saschagrunert

@puerco puerco

@cpanato cpanato

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
8 participants
@justaugustus @xmudrii @cpanato @puerco @k8s-ci-robot @saschagrunert @liggitt @spiffxp