Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional presubmit prow job for GCE PD CSI Driver with csi-proxy v1 #22636

Closed
wants to merge 1 commit into from
Closed

Add optional presubmit prow job for GCE PD CSI Driver with csi-proxy v1 #22636

wants to merge 1 commit into from

Conversation

mauriciopoppe
Copy link
Member

/cc @jingxu97

@k8s-ci-robot k8s-ci-robot requested a review from jingxu97 June 21, 2021 18:06
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mauriciopoppe
To complete the pull request process, please assign msau42 after the PR has been reviewed.
You can assign the PR to them by writing /assign @msau42 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 21, 2021
@mauriciopoppe mauriciopoppe mentioned this pull request Jun 21, 2021
Merged
@mauriciopoppe
Copy link
Member Author

/hold

The version should have the suffix gke, we will wait until the binary is available

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2021
@mauriciopoppe mauriciopoppe mentioned this pull request Jun 24, 2021
Merged
@mauriciopoppe
Copy link
Member Author

/hold

@jingxu97 this was an optional job that was supposed to run before merging kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#738, it could still be useful though if we decide to run the presubmit integration job from GCE PD CSI driver with this change before we make changes to https://github.com/kubernetes/kubernetes/blob/ce8b7afc8af35a08adbb88509cd8bac4ea6e0348/cluster/gce/config-common.sh#L167

@mauriciopoppe
Copy link
Member Author

We no longer need this as PD CSI is already using csi-proxy v1
/close

@k8s-ci-robot
Copy link
Contributor

@mauriciopoppe: Closed this PR.

In response to this:

We no longer need this as PD CSI is already using csi-proxy v1
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mauriciopoppe mauriciopoppe deleted the gce-csi-proxy-v1 branch September 7, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 jingxu97 left review comments

Assignees
No one assigned
Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mauriciopoppe @k8s-ci-robot @jingxu97