Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always run pull-aws-ebs-csi-driver-external-test-eks #22396

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Jun 2, 2021

it works in kubernetes-sigs/aws-ebs-csi-driver#907, safe to always run.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 2, 2021
@wongma7
Copy link
Contributor Author

wongma7 commented Jun 2, 2021

/hold

kubernetes-sigs/aws-ebs-csi-driver#907 needs to merge first tho

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 2, 2021
@wongma7
Copy link
Contributor Author

wongma7 commented Jun 11, 2021

kubernetes-sigs/aws-ebs-csi-driver#907 has merged but our sweeper isn't configured to clean up eks clusters yet so enabling this job is a bit risky

@wongma7
Copy link
Contributor Author

wongma7 commented Jun 17, 2021

/hold cancel

with kubernetes-sigs/aws-ebs-csi-driver#933, the sweeper has permission to delete stuff so it's safe to enable the job, we should not leak EKS clusters/associated resources

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2021
@nckturner
Copy link
Contributor

Nice!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit d8a76f1 into kubernetes:master Jun 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 17, 2021
@k8s-ci-robot
Copy link
Contributor

@wongma7: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key aws-ebs-csi-driver-presubmits.yaml using file config/jobs/kubernetes-sigs/aws-ebs-csi-driver/aws-ebs-csi-driver-presubmits.yaml

In response to this:

it works in kubernetes-sigs/aws-ebs-csi-driver#907, safe to always run.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants