-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kops - migrate presubmit network plugin jobs to kubetest2 #21609
Conversation
None of the env vars it sets are used by kubetest2 and some conflict with per-job env vars already set by the python script
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rifelpet: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The YAML is different enough that I opted to use a separate template string and
build_*
function rather than using a bunch of conditionals. The only functional change to the job parameters is the cilium job's skip regex is changing:The cluster's configuration should be identical to one of the grid jobs in which we use the new skip regex pattern, so i'm sticking with the new pattern used in the grid jobs. Next we can look into making the other networking jobs' skip patterns more consistent across the board.