Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop specifying master branch in optional kubernetes kind presubmits #21424

Merged
merged 1 commit into from
Mar 17, 2021
Merged

stop specifying master branch in optional kubernetes kind presubmits #21424

merged 1 commit into from
Mar 17, 2021

Conversation

BenTheElder
Copy link
Member

@BenTheElder
stop specifying master branch in optional kubernetes kind presubmits
8fb2053 
- use kind from artifact
- use decorated job instead of bootstrap
- use skip_branches instead of branches
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 17, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2021
BenTheElder
BenTheElder commented Mar 17, 2021
View reviewed changes
config/jobs/kubernetes/sig-testing/conformance-e2e.yaml
- "--job=$(JOB_NAME)"
- "--root=/go/src"
- "--repo=k8s.io/kubernetes=$(PULL_REFS)"
- "--repo=sigs.k8s.io/kind=master"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reported by @jsturtevant https://kubernetes.slack.com/archives/C09QZ4DQB/p1616008878011700

@jsturtevant
Copy link
Contributor

lgtm but I am not super familiar with difference between krte and kubekins images.

@jsturtevant
Copy link
Contributor

/assign @dims

this is blocking kubernetes/kubernetes#100337

@BenTheElder
Copy link
Member Author

images/krte is used by kind jobs and is a focused subset of kubekins for kind
images/kubekins is used by everything under the sun 🙃
They share a variants.yaml to keep the go version in sync.

@aojea
Copy link
Member

aojea commented Mar 17, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2021
@dims
Copy link
Member

dims commented Mar 17, 2021

looks like this has all the stuff to merge :)

/approve
/lgtm

from me as well.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5a68cec into kubernetes:master Mar 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 17, 2021
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key conformance-e2e.yaml using file config/jobs/kubernetes/sig-testing/conformance-e2e.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder BenTheElder deleted the fixup-kind-master branch March 18, 2021 05:29
@BenTheElder BenTheElder mentioned this pull request Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chases2 chases2 Awaiting requested review from chases2

@dims dims Awaiting requested review from dims

Assignees

@dims dims

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
5 participants
@BenTheElder @jsturtevant @aojea @dims @k8s-ci-robot