Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jobs: enforce kubernetes CI policy for blocking jobs #20989

Merged
merged 2 commits into from
Feb 24, 2021
Merged

jobs: enforce kubernetes CI policy for blocking jobs #20989

merged 2 commits into from
Feb 24, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Feb 24, 2021

  • First commit enables "release-blocking must run on k8s-infra"
  • Next commit refactors into "CI Policy" tests instead of individual tests for each policy

I think this is the last thing to do for #18549 but am going to avoid auto-closing with this PR

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 24, 2021
@spiffxp spiffxp mentioned this pull request Feb 24, 2021
Closed
27 tasks
@spiffxp
Copy link
Member Author

spiffxp commented Feb 24, 2021

/uncc @wojtek-t
/cc @thejoycekung
for @kubernetes/ci-signal
/cc @ameukam @hasheddan
SIG Release TL's who've helped with #18549

@k8s-ci-robot k8s-ci-robot requested review from ameukam, hasheddan and thejoycekung and removed request for wojtek-t February 24, 2021 16:59
hasheddan
hasheddan approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @spiffxp!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5796e45 into kubernetes:master Feb 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 24, 2021
@spiffxp spiffxp deleted the kubernetes-blocking-ci-policy branch February 24, 2021 17:44
@spiffxp spiffxp mentioned this pull request Jul 29, 2021
Closed
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@dims dims Awaiting requested review from dims

@ameukam ameukam Awaiting requested review from ameukam

@thejoycekung thejoycekung Awaiting requested review from thejoycekung

Assignees

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @hasheddan