Log or enforce kubernetes jobs pull from k8s-infra buckets #20885
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
sig/testing
|
This is expected to fail until job configs are updated |
|
/uncc @wojtek-t |
k8s-ci-robot
added
the
area/release-eng
| @@ -1086,25 +1086,96 @@ func TestSigReleaseMasterBlockingOrInformingJobsShouldUseFastBuilds(t *testing.T | |||
| } | |||
| } | |||
|
|
|||
| // extractUsesCIBucket returns true if kubetest --extract=foo | |||
There was a problem hiding this comment.
Is this also true for kubetest2?
There was a problem hiding this comment.
I couldn't tell that --extract= was pulling in anything weird so didn't feel the need to add further "is this definitely invoking kubetest in a way we recognize" checks.
/cc @amwat
I think enforcing for kubetest2 is going to require some changes to kubetest2 and the tests here, so I'm opting to ignore for followup later.
- I don't think
kubetest2-gcehas support for extracting pre-built versions of kubernetes yet, its readme states it ned kubetest2-tester-ginkgohas--test-package-bucket (default "kubernetes-release")as a start
There may also be other subprojects that pull from kubernetes-release-dev via scripts we can't introspect here, which I'd like to defer to the broader "remove gs://kubernetes-release-dev" effort which might need to be KEP'ed.
There was a problem hiding this comment.
yeah we don't do published released versions for GCE yet in kubetest2
k8s-ci-robot
added
sig/cli
|
May need to rebase due to #20880 merging |
spiffxp
force-pushed
the
kubetest-jobs-using-k8s-infra-buckets
branch
from
5971a3a to
07851e9
Compare
| @@ -1086,25 +1086,96 @@ func TestSigReleaseMasterBlockingOrInformingJobsShouldUseFastBuilds(t *testing.T | |||
| } | |||
| } | |||
|
|
|||
| // extractUsesCIBucket returns true if kubetest --extract=foo | |||
There was a problem hiding this comment.
yeah we don't do published released versions for GCE yet in kubetest2
Now that we have community-owned CI artifacts, jobs that use them should be pulling CI from gs://k8s-release-dev instead of the google.com-owned gs://kubernetes-release-dev. Setup to enforce/fail for smaller subsets of jobs, and warn for larger sets of jobs over time. This is why there's currently unused code to verify use of gs://k8s-release, and TODOs to enable later. As a start: - Fail any kubetest jobs not extracting from gs://k8s-release-dev if: - they use --extract=ci/latest-fast - they use --extract=ci/* and are release-blocking - Warn any other kubetest jobs not extracting from gs://k8s-release-dev - Warn how many jobs in total need to be fixed
spiffxp
force-pushed
the
kubetest-jobs-using-k8s-infra-buckets
branch
from
07851e9 to
f7c57df
Compare
|
rebased, squashed review fixes into first commit, left job config changes in their own commits |
| fail = true | ||
| jobDesc = "release-blocking jobs" | ||
| } | ||
| fail := isKubernetesReleaseBlocking(job) |
There was a problem hiding this comment.
this can be dropped?
but anyway this code path isn't exercised yet so can be a follow up
There was a problem hiding this comment.
doh, thanks, will followup
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amwat, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@spiffxp: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
To help close out kubernetes/k8s.io#846 (comment)
Now that we have community-owned CI artifacts, jobs that use them should
be pulling CI from gs://k8s-release-dev instead of the google.com-owned
gs://kubernetes-release-dev.
Setup to enforce/fail for smaller subsets of jobs, and warn for larger
sets of jobs over time. This is why there's currently unused code to
verify use of gs://k8s-release, and TODOs to enable later.
As a start:
1also catches --extract=gci/ and --extract=v1.2.3+456 but these aren't in active use here