Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.20] config/prow: enable code freeze for kubernetes/kubernetes master #19930

Merged
merged 1 commit into from
Nov 13, 2020
Merged

[1.20] config/prow: enable code freeze for kubernetes/kubernetes master #19930

merged 1 commit into from
Nov 13, 2020

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Nov 12, 2020

Enable Code Freeze for the master branch

This PR enables code freeze for kubernetes/kubernetes on the master branch.

AI: The release-1.20 branch doesn't exist (the branch creation is scheduled for December 1st), so a follow-up PR for the release-1.20 branch should be made.

/hold
this PR should be merged only after Tuesday, November 12th, PST EOD.

/sig release
/area release-eng

cc: @kubernetes/release-team-leads @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 12, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 12, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Nov 12, 2020

/retest

@justaugustus
Copy link
Member

/test all

cpanato
cpanato approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2020
@justaugustus
Copy link
Member

/lgtm
/approve

Explicit hold while we continue to monitor the situation with git fetch/merge operations (ref: #19910)

saschagrunert
saschagrunert approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

hasheddan
hasheddan approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dims
Copy link
Member

dims commented Nov 13, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, hasheddan, justaugustus, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2020
@kikisdeliveryservice
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2c0beb5 into kubernetes:master Nov 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 13, 2020
@k8s-ci-robot
Copy link
Contributor

@xmudrii: Updated the config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key config.yaml using file config/prow/config.yaml

In response to this:

Enable Code Freeze for the master branch

This PR enables code freeze for kubernetes/kubernetes on the master branch.

AI: The release-1.20 branch doesn't exist (the branch creation is scheduled for December 1st), so a follow-up PR for the release-1.20 branch should be made.

/hold
this PR should be merged only after Tuesday, November 12th, PST EOD.

/sig release
/area release-eng

cc: @kubernetes/release-team-leads @kubernetes/release-engineering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii xmudrii deleted the code-freeze-1.20 branch November 13, 2020 14:21
@xmudrii xmudrii mentioned this pull request Dec 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@cpanato cpanato cpanato approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@cblecker cblecker Awaiting requested review from cblecker

@dims dims Awaiting requested review from dims

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@justaugustus justaugustus

@saschagrunert saschagrunert

@cpanato cpanato

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
8 participants
@xmudrii @justaugustus @dims @k8s-ci-robot @kikisdeliveryservice @saschagrunert @cpanato @hasheddan