-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAPZ: add pull-cluster-api-provider-azure-conformance-with-ci-artifacts #19767
CAPZ: add pull-cluster-api-provider-azure-conformance-with-ci-artifacts #19767
Conversation
/assign @cpanato @randomvariable |
@@ -225,8 +225,6 @@ presubmits: | |||
- "runner.sh" | |||
- "./scripts/ci-conformance.sh" | |||
env: | |||
- name: GINKGO_FOCUS | |||
value: "Conformance Tests" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will be set in the makefile by default now
resources: | ||
requests: | ||
cpu: 2 | ||
memory: "9Gi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beefy, is there a reason for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to set the requests for every prow job otherwise we can mess with the cluster.
The values we need to check if is enough, otherwise just increase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, cpanato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@CecileRobertMichon: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Adds a presubmit for conformance with CI artifacts to test kubernetes-sigs/cluster-api-provider-azure#1018