Allow staging via krel for kubetest #19328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
4 tasks
k8s-ci-robot
added
area/kubetest
sig/testing
saschagrunert
commented
Sep 23, 2020
saschagrunert
commented
Sep 23, 2020
saschagrunert
force-pushed
the
stage-via-krel
branch
2 times, most recently
from
f86a335 to
8bf0091
Compare
k8s-ci-robot
added
size/XL
saschagrunert
force-pushed
the
stage-via-krel
branch
7 times, most recently
from
548d181 to
33a9de4
Compare
k8s-ci-robot
added
size/XXL
saschagrunert
force-pushed
the
stage-via-krel
branch
3 times, most recently
from
a31c168 to
f833196
Compare
k8s-ci-robot
added
size/M
saschagrunert
force-pushed
the
stage-via-krel
branch
from
f833196 to
978d1c4
Compare
k8s-ci-robot
removed
the
size/M
k8s-ci-robot
added
the
size/L
saschagrunert
force-pushed
the
stage-via-krel
branch
from
978d1c4 to
d2bf86b
Compare
k8s-ci-robot
added
size/XXL
saschagrunert
force-pushed
the
stage-via-krel
branch
from
d2bf86b to
bf19bc0
Compare
k8s-ci-robot
added
size/XL
This adds a new `--use-krel` flag to kubetest to indicate that we want to stage the sources directly via the API provided by k/release rather than the deprecated push-build.sh script (lives in k/release, too). The idea is to add another job later on for testing this flag on a non critical Kubernetes build+push job (should live in sig-release). Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
stage-via-krel
branch
from
bf19bc0 to
40ad443
Compare
k8s-ci-robot
added
size/M
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@saschagrunert: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
saschagrunert
commented
Sep 24, 2020
| return errors.Wrap( | ||
| release.NewPushBuild(&release.PushBuildOptions{ | ||
| Bucket: s.bucket, | ||
| BuildDir: "_output", |
There was a problem hiding this comment.
TODO: We need a const for this somewhere, or a DefaultPushBuildOptions() API.
|
I'll move these changes into kubetest2 and then we will continue there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
--use-krelflag to kubetest to indicate that we wantto stage the sources directly via the API provided by k/release rather
than the deprecated push-build.sh script (lives in k/release, too).
The idea is to add another job later on for testing this flag on a non
critical Kubernetes build+push job (should live in sig-release).
Refers to kubernetes/release#1578, kubernetes/release#1459