Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kops - Fix branch names for release pipelines #18260

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 10, 2020

Just fixing a typo :)

/cc @rifelpet

@k8s-ci-robot k8s-ci-robot requested a review from rifelpet July 10, 2020 11:46
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 10, 2020
@rifelpet
Copy link
Member

I ran the python scripts with these changes in it and got a few more changes in the yaml file than what is in this PR so we should make sure those are included as well.

Also is this to fix a failing job that is looking for a release marker in a different place than where this is publishing it? if so can you link to that job? just so I understand the full picture here.

@hakman
Copy link
Member Author

hakman commented Jul 10, 2020

The release ci-latest.txt comes from this PR: kubernetes/kops#9272 and _PULL_BASE_REF seems to be the branch name.

The pipeline job will use the ci-latest.txt file and, if it passes, will update latest-ci-updown-green.txt.

I think the script incorrectly assumes the branch mane as $VERSION instead of release-SVERSION.

@hakman hakman force-pushed the fix-pipeline-markers branch from 5f37827 to 7995986 Compare July 10, 2020 15:08
@rifelpet
Copy link
Member

ok that makes sense to me. thanks for the explanation 👍
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5fb166d into kubernetes:master Jul 10, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 10, 2020
@k8s-ci-robot
Copy link
Contributor

@hakman: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key kops-pipeline.yaml using file config/jobs/kubernetes/kops/kops-pipeline.yaml

In response to this:

Just fixing a typo :)

/cc @rifelpet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants