-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kops - Fix branch names for release pipelines #18260
Conversation
I ran the python scripts with these changes in it and got a few more changes in the yaml file than what is in this PR so we should make sure those are included as well. Also is this to fix a failing job that is looking for a release marker in a different place than where this is publishing it? if so can you link to that job? just so I understand the full picture here. |
The release The pipeline job will use the I think the script incorrectly assumes the branch mane as |
5f37827
to
7995986
Compare
ok that makes sense to me. thanks for the explanation 👍 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@hakman: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Just fixing a typo :)
/cc @rifelpet