Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow use of vhds in aks-engine #18160

Closed
wants to merge 1 commit into from
Closed

Allow use of vhds in aks-engine #18160

wants to merge 1 commit into from

Conversation

jsturtevant
Copy link
Contributor

This helps solve issue kubernetes/kubernetes#92771 and kubernetes-sigs/windows-testing#177 where tests are flaking because of a node reboot. Using a different VHD specified in the sig-windows template resolves this issue and speeds up the tests.

This requires a change to aks-engine to use kubectl and kubelet built from kubernetes job that @chewong is working on.
/hold
/sig windows

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 3, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @jsturtevant. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/kubetest sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsturtevant
To complete the pull request process, please assign shyamjvs
You can assign the PR to them by writing /assign @shyamjvs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from amwat and feiskyer July 3, 2020 00:20
@chewong
Copy link
Member

chewong commented Jul 3, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 3, 2020
feiskyer
feiskyer reviewed Jul 4, 2020
View reviewed changes
kubetest/aksengine.go
@@ -493,15 +493,6 @@ func (c *aksEngineDeployer) populateAPIModelTemplate() error {
return fmt.Errorf("No template file specified %v", err)
}

// set default distro so we do not use prebuilt os image
if v.Properties.MasterProfile.Distro == "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting distro from aks-engine.json would override the defaults here, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that's the path we ended up taking: kubernetes-sigs/windows-testing#178

@jsturtevant jsturtevant closed this Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chewong chewong chewong left review comments

@feiskyer feiskyer feiskyer left review comments

@amwat amwat Awaiting requested review from amwat

Assignees
No one assigned
Labels
area/kubetest cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsturtevant @k8s-ci-robot @chewong @feiskyer