Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reintroduce ci-k8sio-backup job #17150

Merged
merged 2 commits into from
Apr 8, 2020
Merged

reintroduce ci-k8sio-backup job #17150

merged 2 commits into from
Apr 8, 2020

Conversation

listx
Copy link
Contributor

@listx listx commented Apr 8, 2020

This is blocked on kubernetes/k8s.io#718.

/assign @spiffxp

Linus Arver added 2 commits April 8, 2020 00:16
Revert "ci-k8sio-backup: remove job"
5e237bf 
This reverts commit a6a2655.

The backup job has received some optimizations in
kubernetes/k8s.io#677, In addition, the
k8s-artifacts-prod-bak GCR has been manually pre-populated with all ~30K
images in k8s-artifacts-prod for all ASIA, EU, and US regions, which
will result in jobs taking just minutes to run (as subsequent runs are
mostly NOP runs).

For more discussion on the backup job, please see
https://docs.google.com/document/d/11eiosJvm2xEVUhPRU3-luANxxTPL5FqQdJXVrLPImyQ/edit?usp=sharing.
ci-k8sio-backup: use workload identity
081901e 
See kubernetes/k8s.io#718 for binding the KSA to
the

    k8s-infra-gcr-promoter@k8s-artifacts-prod-bak.iam.gserviceaccount.com

account referenced in this PR.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 8, 2020
@k8s-ci-robot k8s-ci-robot requested review from ixdy and wojtek-t April 8, 2020 07:22
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/prow Issues or PRs related to prow area/prow/bump Updates to the k8s prow cluster sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 8, 2020
@spiffxp
Copy link
Member

spiffxp commented Apr 8, 2020

/approve
/lgtm
/hold
/assign @cjwagner @fejta
I can't remember if the service account will get auto-deployed on merge, so I'm pinging you two for the /hold in case something manual needs to happen

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: listx, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2020
@spiffxp
Copy link
Member

spiffxp commented Apr 8, 2020

/hold cancel
answering my own question: post-test-infra-deploy-prow should pick it up

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit 32d93e0 into kubernetes:master Apr 8, 2020
@k8s-ci-robot
Copy link
Contributor

@listx: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key test-infra-trusted.yaml using file config/jobs/kubernetes/test-infra/test-infra-trusted.yaml

In response to this:

This is blocked on kubernetes/k8s.io#718.

/assign @spiffxp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@listx
Copy link
Contributor Author

listx commented Apr 9, 2020

/approve
/lgtm
/hold
/assign @cjwagner @fejta
I can't remember if the service account will get auto-deployed on merge, so I'm pinging you two for the /hold in case something manual needs to happen

I distinctly recall @fejta saying that the SA will get auto-deployed on merge. It's a bit moot as you answered your own question but I just thought I'd share for the record, albeit belatedly.

@listx
Copy link
Contributor Author

listx commented Apr 9, 2020

Strange, despite what I just posted, the job is showing an error that it cannot find the service account:

status:
  completionTime: "2020-04-08T23:41:20Z"
  description: 'Job cannot be started: pods "67604f2b-79f2-11ea-81ca-8e4c2b7d37f3"
    is forbidden: error looking up service account test-pods/k8s-infra-gcr-promoter-bak:
    serviceaccount "k8s-infra-gcr-promoter-bak" not found'

Maybe some manual intervention is required? @spiffxp

@listx
Copy link
Contributor Author

listx commented Apr 9, 2020

Hmm, it looks like the latest job ran successfully at ~4AM. I guess it was just a config timing (or deployment timing) issue.

Thanks!

@listx listx mentioned this pull request Apr 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixdy ixdy Awaiting requested review from ixdy

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@spiffxp spiffxp

@fejta fejta

@cjwagner cjwagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/prow/bump Updates to the k8s prow cluster area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@listx @spiffxp @k8s-ci-robot @fejta @cjwagner