Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ingress-nginx jobs #16490

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Update ingress-nginx jobs #16490

merged 1 commit into from
Feb 26, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Feb 26, 2020 •
edited
Loading

Update go to 1.14 and include chart testing binary.

xref: kubernetes/ingress-nginx#5161

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 26, 2020
@aledbf
Copy link
Member Author

aledbf commented Feb 26, 2020

/assign @MrHohn

@BenTheElder
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6bca79b into kubernetes:master Feb 26, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 26, 2020
@k8s-ci-robot
Copy link
Contributor

@aledbf: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key ingress-nginx.yaml using file config/jobs/kubernetes/sig-network/ingress-nginx.yaml

In response to this:

Update go to 1.14 and include chart testing binary.

xref: kubernetes/ingress-nginx#5161

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aledbf aledbf deleted the ingress-nginx branch February 26, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BenTheElder BenTheElder

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@aledbf @BenTheElder @k8s-ci-robot @MrHohn