Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable prometheus server for APIResponsiveness test #16327

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Enable prometheus server for APIResponsiveness test #16327

merged 1 commit into from
Feb 24, 2020

Conversation

YangLu1031
Copy link
Contributor

APIResponsiveness test depends on Prometheus server which couldn't scrape kube-proxy, unless it’s binding 0.0.0.0 as per helm/charts#16476

Referrence: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-scalability/sig-scalability-presets.yaml#L127

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 17, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Feb 17, 2020
@chases2 chases2 removed their request for review February 20, 2020 18:52
chases2
chases2 reviewed Feb 20, 2020
View reviewed changes
config/jobs/kubernetes/sig-windows/windows-gce.yaml Outdated
@@ -42,6 +42,11 @@ presets:
value: "128"
- name: PREPULL_TIMEOUT
value: "10m"
# APIResponsiveness test depends on Prometheus server which couldn't scrape kube-proxy,
# unless it’s binding 0.0.0.0 as per https://github.com/helm/charts/issues/16476
# Referrence: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-scalability/sig-scalability-presets.yaml#L127
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the typo here, and you should pass unit tests.
Looking for direct OWNERS to approve:
/cc @PatrickLang @benmoss

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd defer to @pjh here, I don't have any context on this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@YangLu1031
Copy link
Contributor Author

/cc @pjh

@k8s-ci-robot k8s-ci-robot requested a review from pjh February 21, 2020 10:28
@YangLu1031
Copy link
Contributor Author

/cc @yliaog

@k8s-ci-robot k8s-ci-robot requested a review from yliaog February 23, 2020 10:46
@yliaog
Copy link
Contributor

yliaog commented Feb 24, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YangLu1031, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6a455f4 into kubernetes:master Feb 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 24, 2020
@k8s-ci-robot
Copy link
Contributor

@YangLu1031: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key windows-gce.yaml using file config/jobs/kubernetes/sig-windows/windows-gce.yaml

In response to this:

APIResponsiveness test depends on Prometheus server which couldn't scrape kube-proxy, unless it’s binding 0.0.0.0 as per helm/charts#16476

Referrence: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-scalability/sig-scalability-presets.yaml#L127

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chases2 chases2 chases2 left review comments

@ddebroy ddebroy Awaiting requested review from ddebroy

@benmoss benmoss Awaiting requested review from benmoss

@PatrickLang PatrickLang Awaiting requested review from PatrickLang

@pjh pjh Awaiting requested review from pjh

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
5 participants
@YangLu1031 @yliaog @k8s-ci-robot @benmoss @chases2