Populate a bare-minimum Azure cloud config #15538
Conversation
k8s-ci-robot
added
cncf-cla: yes
| "aadClientId": c.credentials.ClientID, | ||
| "aadClientSecret": c.credentials.ClientSecret, | ||
| "resourceGroup": c.resourceGroup, | ||
| "location": c.location, |
There was a problem hiding this comment.
could we also add vmType to the cloudConfig? It would be required to determine wether a node is VM or VMSSVM. If it is hard to determine the vm type, we could use "vmss" as it supports both VM and VMSSVM.
There was a problem hiding this comment.
PTAL at the PR. Is there any other fields that I should add to the cloud config?
There was a problem hiding this comment.
thanks for the update, I think that's enough
|
/area provider/azure |
k8s-ci-robot
added
the
area/provider/azure
chewong
force-pushed
the
azure-cloud-config
branch
from
efd95a0 to
892de24
Compare
chewong
force-pushed
the
azure-cloud-config
branch
from
892de24 to
8918eb7
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chewong, feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This PR enables Azure deployer to populate a bare-minimum Azure cloud config as it is required if we set the test provider to Azure.
This is useful when we start running Azure-specific e2e tests in upstream k8s such as in-tree Azure Disk volume plugin and Azure Disk CSI driver since those tests are skipped automatically unless we set the provider to
azure./assign @feiskyer