Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust blackbox prober additional scrape targets. #15209

Merged
merged 1 commit into from
Nov 11, 2019

Conversation

cjwagner
Copy link
Member

@cjwagner cjwagner commented Nov 8, 2019

  1. Scraping https://prow.k8s.io/hook results in 405, not 200. (We don't really need to scrape /hook anyways since the hook service is already monitored for availability in the cluster and the https://prow.k8s.io probe validates that the DNS is working.)
  2. The two go.k8s.io probes are failing to follow redirects even though we have explicitly specified that redirects should be followed:

    This is due to this blackbox exporter bug Redirect to different HTTPS host broken prometheus/blackbox_exporter#237 which should be resolved by Better handling of HTTP redirects. prometheus/blackbox_exporter#530, but there has not been a release cut since that fix merged: https://github.com/prometheus/blackbox_exporter/releases
    Resolving this for now by using the redirect URLs.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 8, 2019
@cjwagner
Copy link
Member Author

cjwagner commented Nov 8, 2019

/assign @stevekuznetsov @hongkailiu

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow area/prow/bump Updates to the k8s prow cluster sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 8, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0bf5a0a into kubernetes:master Nov 11, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 11, 2019
@cjwagner cjwagner deleted the probe-adjustments branch November 12, 2019 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/bump Updates to the k8s prow cluster area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants