Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 1.16 jobs and specify specific K8s patch versions #15055

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Add 1.16 jobs and specify specific K8s patch versions #15055

merged 1 commit into from
Nov 5, 2019

Conversation

msau42
Copy link
Member

@msau42 msau42 commented Nov 1, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 1, 2019
@k8s-ci-robot k8s-ci-robot requested review from chases2 and pohly November 1, 2019 01:05
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 1, 2019
@msau42
Copy link
Member Author

msau42 commented Nov 1, 2019

Testing 1.16.2 in kubernetes-csi/csi-driver-host-path#100

@msau42
Copy link
Member Author

msau42 commented Nov 1, 2019

/assign @pohly

pohly
pohly requested changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just one minor comment on the script.

config/jobs/kubernetes-csi/gen-jobs.sh Outdated
@@ -265,7 +273,7 @@ EOF
cat >>"$base/$repo/$repo-config.yaml" <<EOF
- name: $(job_name "pull" "$repo" "$tests" "$deployment" "$kubernetes")
always_run: $(pull_alwaysrun "$tests")
optional: $(pull_optional "$tests")
optional: $(if [ "$kubernetes" = "1.16.2" ]; then echo true; else pull_optional "$tests"; fi)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This special case is not obvious and deserves a comment. Perhaps change this into optional: $(pull_optional "$kubernetes" "$tests") and then inside the extended implementation of pull_optional explain why 1.16.2 is an exception?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

pohly
pohly approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

config/jobs/kubernetes-csi/gen-jobs.sh
elif [ "$kubernetes" == "1.16.2" ]; then
# Testing 1.16 requires release-tools to be updated in all
# kubernetes-csi repos. Once that is done, and tests
# are passing, this can be removed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are almost done with that. Only kubernetes-csi/node-driver-registrar#53 and kubernetes-csi/external-snapshotter#188 are pending.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 16cb8d2 into kubernetes:master Nov 5, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 5, 2019
@k8s-ci-robot
Copy link
Contributor

@msau42: Updated the job-config configmap in namespace default using the following files:

  • key csi-driver-host-path-config.yaml using file config/jobs/kubernetes-csi/csi-driver-host-path/csi-driver-host-path-config.yaml
  • key external-attacher-config.yaml using file config/jobs/kubernetes-csi/external-attacher/external-attacher-config.yaml
  • key external-provisioner-config.yaml using file config/jobs/kubernetes-csi/external-provisioner/external-provisioner-config.yaml
  • key external-resizer-config.yaml using file config/jobs/kubernetes-csi/external-resizer/external-resizer-config.yaml
  • key external-snapshotter-config.yaml using file config/jobs/kubernetes-csi/external-snapshotter/external-snapshotter-config.yaml
  • key livenessprobe-config.yaml using file config/jobs/kubernetes-csi/livenessprobe/livenessprobe-config.yaml
  • key node-driver-registrar-config.yaml using file config/jobs/kubernetes-csi/node-driver-registrar/node-driver-registrar-config.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly approved these changes

@chases2 chases2 Awaiting requested review from chases2

Assignees

@pohly pohly

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.
3 participants
@msau42 @k8s-ci-robot @pohly