-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate aws-janitor #14755
Reinstate aws-janitor #14755
Conversation
This reverts commit c8a4497.
It's not an error; this is the janitor doing what it is supposed to. It makes it look like the janitor is failing, when in fact another job is leaking resources.
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chases2: 0 warnings.
In response to this:
/lgtm
/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/cc @amwat |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @detiber |
/lgtm |
@justinsb: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In particular, stop exiting with a non-zero exit code when we cleaned
up some resources.
That's not an error; this is the janitor doing what it is supposed
to. It makes it look like the janitor is failing, when in fact another
job is leaking resources.