Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate aws-janitor #14755

Merged

Conversation

justinsb
Copy link
Member

In particular, stop exiting with a non-zero exit code when we cleaned
up some resources.

That's not an error; this is the janitor doing what it is supposed
to. It makes it look like the janitor is failing, when in fact another
job is leaking resources.

It's not an error; this is the janitor doing what it is supposed to.
It makes it look like the janitor is failing, when in fact another
job is leaking resources.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 14, 2019
@chases2
Copy link
Contributor

chases2 commented Oct 15, 2019

/lgtm
/lint

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2019
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chases2: 0 warnings.

In response to this:

/lgtm
/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member

/cc @amwat

@k8s-ci-robot k8s-ci-robot requested a review from amwat October 17, 2019 08:21
@BenTheElder
Copy link
Member

/approve
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2019
@BenTheElder
Copy link
Member

/cc @detiber

@k8s-ci-robot k8s-ci-robot requested a review from detiber October 22, 2019 00:22
@detiber
Copy link
Member

detiber commented Oct 22, 2019

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 96cbeee into kubernetes:master Oct 22, 2019
@k8s-ci-robot
Copy link
Contributor

@justinsb: Updated the job-config configmap in namespace default using the following files:

  • key janitors.yaml using file config/jobs/kubernetes/test-infra/janitors.yaml

In response to this:

In particular, stop exiting with a non-zero exit code when we cleaned
up some resources.

That's not an error; this is the janitor doing what it is supposed
to. It makes it look like the janitor is failing, when in fact another
job is leaking resources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants