Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ci-npd-e2e-test job to run npd e2e tests #14372

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

xueweiz
Copy link
Contributor

@xueweiz xueweiz commented Sep 17, 2019

The tests has been running internally for a while.

This PR is part of #14369 and kubernetes/node-problem-detector#296

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 17, 2019
@xueweiz
Copy link
Contributor Author

xueweiz commented Sep 17, 2019

/assign @krzyzacy
/cc @wangzhen127

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 17, 2019
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 17, 2019
@krzyzacy
Copy link
Member

(please avoid pasting internal links to OSS)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 71a1ba0b3329508df6df74e1878e6deec2fa7120

@krzyzacy
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy, xueweiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2019
@xueweiz
Copy link
Contributor Author

xueweiz commented Sep 17, 2019

I see. Will keep that in mind. Thanks! :)

@k8s-ci-robot k8s-ci-robot merged commit 406ea10 into kubernetes:master Sep 17, 2019
@k8s-ci-robot
Copy link
Contributor

@xueweiz: Updated the job-config configmap in namespace default using the following files:

  • key node-problem-detector-ci.yaml using file config/jobs/kubernetes/node-problem-detector/node-problem-detector-ci.yaml

In response to this:

The tests has been running internally for a while.

This PR is part of #14369 and kubernetes/node-problem-detector#296

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants