Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump image for metrics-bigquery job #13953

Merged
merged 1 commit into from
Aug 17, 2019

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 16, 2019

Followup for #13912

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2019
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2019
@spiffxp
Copy link
Member Author

spiffxp commented Aug 17, 2019

/assign @clarketm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 037f3ca456c2b8b7ab7789e29d5b8dfb42cbca95

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, clarketm, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 551edb4 into kubernetes:master Aug 17, 2019
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default using the following files:

  • key test-infra-periodics.yaml using file config/jobs/kubernetes/test-infra/test-infra-periodics.yaml

In response to this:

Followup for #13912

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 17, 2019
@spiffxp spiffxp deleted the bump-metrics-image-for-py3 branch August 17, 2019 01:25
@spiffxp
Copy link
Member Author

spiffxp commented Aug 17, 2019

I tried using prow's rerun functionality to test the job, but I forget that rerun runs the same spec (with the old image), so I just confirmed that yes, the py3 metrics code won't work with the old image https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/metrics-bigquery/1162510317721227273/

I don't have rights to the cluster to manually edit the prowjob yaml and schedule it myself, so I'll just see what tomorrow's run brings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants