Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #13648 from cblecker/default-goproxy" #13674

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Revert "Merge pull request #13648 from cblecker/default-goproxy" #13674

merged 1 commit into from
Jul 30, 2019

Conversation

cblecker
Copy link
Member

This reverts commit b84ad08, reversing
changes made to 57a4dc6.

@cblecker
Revert "Merge pull request kubernetes#13648 from cblecker/default-gop…
2fdd9cc 
…roxy"

This reverts commit b84ad08, reversing
changes made to 57a4dc6.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/prow Issues or PRs related to prow sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 30, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fa0257287fd20dcd62db668d4519f7d5b741c5b7

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, cjwagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 028b90c into kubernetes:master Jul 30, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 30, 2019
@k8s-ci-robot
Copy link
Contributor

@cblecker: Updated the following 2 configmaps:

  • job-config configmap in namespace default using the following files:
    • key generated-security-jobs.yaml using file config/jobs/kubernetes-security/generated-security-jobs.yaml
    • key dependencies.yaml using file config/jobs/kubernetes/sig-testing/dependencies.yaml
  • config configmap in namespace default using the following files:
    • key config.yaml using file prow/config.yaml

In response to this:

This reverts commit b84ad08, reversing
changes made to 57a4dc6.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker cblecker deleted the revert-13648 branch July 30, 2019 02:27
@spiffxp spiffxp mentioned this pull request Jul 30, 2019
Merged
cblecker added a commit to cblecker/test-infra that referenced this pull request Jul 30, 2019
@cblecker
Revert "Merge pull request kubernetes#13674 from cblecker/revert-13648"
ab89dd9 
This reverts commit 028b90c, reversing
changes made to a8aa5df.
cblecker added a commit to cblecker/test-infra that referenced this pull request Jul 30, 2019
@cblecker
Revert "Merge pull request kubernetes#13674 from cblecker/revert-13648"
f9b2f97 
This reverts commit 028b90c, reversing
changes made to a8aa5df.
cblecker added a commit to cblecker/test-infra that referenced this pull request Jul 31, 2019
@cblecker
Revert "Merge pull request kubernetes#13674 from cblecker/revert-13648"
66c39e9 
This reverts commit 028b90c, reversing
changes made to a8aa5df.
k8s-ci-robot added a commit that referenced this pull request Jul 31, 2019
@k8s-ci-robot
Merge pull request #13686 from cblecker/revert-revert-13648
66dc129 
Revert "Merge pull request #13674 from cblecker/revert-13648"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjwagner cjwagner cjwagner approved these changes

@alvaroaleman alvaroaleman Awaiting requested review from alvaroaleman

@matthyx matthyx Awaiting requested review from matthyx

Assignees

@cjwagner cjwagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
3 participants
@cblecker @k8s-ci-robot @cjwagner