Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kops pr e2e: tell kops to deploy the 1.15 version #13357

Merged
merged 1 commit into from
Jul 9, 2019
Merged

kops pr e2e: tell kops to deploy the 1.15 version #13357

merged 1 commit into from
Jul 9, 2019

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Jul 8, 2019

Following on to #13320, it looks like we are using the 1.15 branch of
k8s for the e2e tests, but we are still telling kops to deploy the
latest version. KOPS_DEPLOY_LATEST_URL seems to be the magic env var.

@justinsb
kops pr e2e: tell kops to deploy the 1.15 version
cacf4b4 
Following on to kubernetes#13320, it looks like we are using the 1.15 branch of
k8s for the e2e tests, but we are still telling kops to deploy the
latest version.  KOPS_DEPLOY_LATEST_URL seems to be the magic env var.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 8, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 8, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 552c11252aff4ade1b649586b22f4c707abe168d

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justinsb
Copy link
Member Author

justinsb commented Jul 9, 2019

/test pull-test-infra-bazel

@k8s-ci-robot k8s-ci-robot merged commit 26fe5f3 into kubernetes:master Jul 9, 2019
@k8s-ci-robot
Copy link
Contributor

@justinsb: Updated the job-config configmap in namespace default using the following files:

  • key kops-config.yaml using file config/jobs/kubernetes/kops/kops-config.yaml

In response to this:

Following on to #13320, it looks like we are using the 1.15 branch of
k8s for the e2e tests, but we are still telling kops to deploy the
latest version. KOPS_DEPLOY_LATEST_URL seems to be the magic env var.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justinsb justinsb mentioned this pull request Jul 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@chrislovecnm chrislovecnm Awaiting requested review from chrislovecnm

@cjwagner cjwagner Awaiting requested review from cjwagner

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinsb @k8s-ci-robot @BenTheElder