Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Code Freeze for 1.15 #12808

Merged
merged 1 commit into from
May 31, 2019
Merged

Enable Code Freeze for 1.15 #12808

merged 1 commit into from
May 31, 2019

Conversation

imkin
Copy link

@imkin imkin commented May 30, 2019

/assign @spiffxp
/assign @claurence

Code freeze is May 30th PST EOD.

cc @Katharine @mariantalla @taragu

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 30, 2019
@k8s-ci-robot k8s-ci-robot requested review from cblecker and fejta May 30, 2019 01:07
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 30, 2019
@imkin
Copy link
Author

imkin commented May 30, 2019

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/prow Issues or PRs related to prow sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 30, 2019
@spiffxp
Copy link
Member

spiffxp commented May 30, 2019

/approve
/lgtm
Please /hold cancel at your discretion when you're ready to enable freeze

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8d7838bbf76fa9786d78e7a34164f1bae6660b7f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imkin, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2019
@claurence
Copy link

claurence commented May 31, 2019 •
edited
Loading

Holding off approving until tomorrow given issues with Prow today and the long queue of PRs for 1.15 still waiting to be merged. Will reassess tomorrow after burndown

@claurence
Copy link

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2019
@Katharine Katharine merged commit a5deab7 into kubernetes:master May 31, 2019
@k8s-ci-robot
Copy link
Contributor

@imkin: Updated the config configmap in namespace default using the following files:

  • key config.yaml using file prow/config.yaml

In response to this:

/assign @spiffxp
/assign @claurence

Code freeze is May 30th PST EOD.

cc @Katharine @mariantalla @taragu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker Awaiting requested review from cblecker

@fejta fejta Awaiting requested review from fejta

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@spiffxp spiffxp

@claurence claurence

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@imkin @spiffxp @k8s-ci-robot @claurence @Katharine