Make needs-rebase label red

[spiffxp]

Looking at the tide queries in use today, needs-rebase is merge-blocking for all kubernetes orgs, so yeah I think it's time to make it the same shade of red as do-not-merge/foo labels (it should really be a do-not-merge/needs-rebase label, I will follow up with that)

/hold
I'm using this to verify that @k8s-github-robot can run label_sync

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• label_sync/OWNERS [spiffxp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nikhita]

/sig contributor-experience

[cblecker]

I personally will miss the grey. Not a hill worth dying on though. #sig-bikeshed

[nikhita]

I personally will miss the grey.

Haha me too. :P

But the rationale makes sense here so ¯\_(ツ)_/¯

[fejta]

IMO we should reserve red for merge-blocking conditions, and not all of these do that.

[spiffxp]

rebased

taking another look at this, because if we're not actually blocking merge on these, maybe they should stay as-is

[spiffxp]

Looking at the tide queries in use today, needs-rebase is merge-blocking for all kubernetes orgs, so yeah I think it's time to make it the same shade of red as do-not-merge/foo labels (it should really be a do-not-merge/needs-rebase label, I will follow up with that)

I went down a rabbit hole trying to rationalize the others and honestly, it's not worth the effort right now. The needs-kind and needs-sig labels are applied both to issues and PR's, and they aren't applied in most repos. I feel like having a needs-sig label for issues, and do-not-merge/needs-sig label for PR's is maybe more self-explanatory, and would rather no go through that now. Given that there's a desire to redo triage workflow anyway (ref: kubernetes/community#3456), I'm not going to touch them.

[nikhita]

👍

[spiffxp]

/hold cancel
I'm also not anywhere close to being able to test out what I wanted to use this to test out, so I'm just gonna let it deploy pending /lgtm

[cblecker]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: d18507bcf9e948072b3644a514309ac5b07a89a0

[k8s-ci-robot]

@spiffxp: Updated the label-config configmap in namespace test-pods using the following files:

• key labels.yaml using file label_sync/labels.yaml

In response to this:

Looking at the tide queries in use today, needs-rebase is merge-blocking for all kubernetes orgs, so yeah I think it's time to make it the same shade of red as do-not-merge/foo labels (it should really be a do-not-merge/needs-rebase label, I will follow up with that)

/hold
I'm using this to verify that @k8s-github-robot can run label_sync

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.