Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

path-alias k/k into k8s.io/kubernetes #11129

Merged
merged 1 commit into from
Feb 5, 2019
Merged

path-alias k/k into k8s.io/kubernetes #11129

merged 1 commit into from
Feb 5, 2019

Conversation

krzyzacy
Copy link
Member

@krzyzacy krzyzacy commented Feb 5, 2019

aaaaalmost

Initialized empty Git repository in /home/prow/go/src/github.com/kubernetes/kubernetes/.git/

2019/02/05 16:47:35 util.go:46: Warning: Couldn't find directory src/k8s.io/kubernetes under any of GOPATH /home/prow/go, defaulting to /home/prow/go/src/k8s.io/kubernetes

/assign @neolit123 @BenTheElder

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 5, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2019
luxas
luxas approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8ebc921bf131998e0d148c7c53448c9cda9a0916

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy, luxas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit baed5c3 into kubernetes:master Feb 5, 2019
@k8s-ci-robot
Copy link
Contributor

@krzyzacy: Updated the job-config configmap using the following files:

  • key generated-security-jobs.yaml using file config/jobs/kubernetes-security/generated-security-jobs.yaml
  • key kubeadm.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm.yaml

In response to this:

aaaaalmost

Initialized empty Git repository in /home/prow/go/src/github.com/kubernetes/kubernetes/.git/

2019/02/05 16:47:35 util.go:46: Warning: Couldn't find directory src/k8s.io/kubernetes under any of GOPATH /home/prow/go, defaulting to /home/prow/go/src/k8s.io/kubernetes

/assign @neolit123 @BenTheElder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

neolit123
neolit123 reviewed Feb 5, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
🤞

@krzyzacy
Copy link
Member Author

krzyzacy commented Feb 5, 2019

yeah - that worked, now it's failing within the k-a deployer, probably the deployer flags are messed up

@krzyzacy krzyzacy deleted the fix-kubeadm branch February 5, 2019 20:52
@neolit123
Copy link
Member

neolit123 commented Feb 5, 2019 •
edited
Loading

we have a breakage in the periodics too it seems:
https://k8s-testgrid.appspot.com/sig-cluster-lifecycle-all#kubeadm-gce-master

🙄
looking..

edit: kubernetes/kubernetes#73402

@krzyzacy
Copy link
Member Author

krzyzacy commented Feb 5, 2019 

E0205 18:29:19.323805    1848 test_context.go:430] Unknown provider "kubernetes-anywhere". The following providers are known: aws azure gce gke kubemark local skeleton

hummmmmmmmmm we... should probably... unify this deployer + provider bash...

@neolit123
Copy link
Member

neolit123 commented Feb 5, 2019 •
edited
Loading

i don't understand where this value of kubernetes-anywhere comes from. :(
the only place where we still do this is here:
https://github.com/kubernetes/test-infra/blob/master/kubetest/anywhere.go#L270-L288

but this is for the log dump.

@neolit123
Copy link
Member

neolit123 commented Feb 5, 2019 •
edited
Loading

seems to me like the log dump is coupled with e2e and that's why it fails.

my last bet is to modify this line to be "gce" instead of "kubernetes-anywhere"
https://github.com/kubernetes/test-infra/blob/master/kubetest/anywhere.go#L280

as per:
https://github.com/kubernetes/kubernetes/blob/master/cluster/log-dump/log-dump.sh#L40-L42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@luxas luxas luxas approved these changes

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@neolit123 neolit123

@BenTheElder BenTheElder

@luxas luxas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@krzyzacy @k8s-ci-robot @neolit123 @luxas @BenTheElder