Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mungegithub misbehaves when github returns 502s #1628

Closed
foxish opened this issue Jan 21, 2017 · 2 comments
Closed

mungegithub misbehaves when github returns 502s #1628

foxish opened this issue Jan 21, 2017 · 2 comments

Comments

@foxish
Copy link
Contributor

foxish commented Jan 21, 2017

From @eparis on April 29, 2016 12:31

Likely a problem because the 'branch name' helper does not return an error, so the munger worked with "" instead of realizing there was an error. The helper was originally intended to check the positive, but was used to check the negative, in which case the distinction of 'error' is important. There are probably other helpers that really should return an error code :-(

github.go:1074] Error commits for PR 24164: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24164/commits?per_page=100: 502 Server Error []
lgtm_after_commit.go:73] PR 24164 unable to determine lastModified or lgtmTime
github.go:428] Error getting PR# 24164: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24164: 502 Server Error []
github.go:428] Error getting PR# 24164: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24164: 502 Server Error []
github.go:627] Adding labels [do-not-merge] to PR 24164
github.go:1327] Commenting "This PR is not for the master branch but does not have the `cherrypick-approved` label. Adding the `do-not-merge` label." in 24164
github.go:428] Error getting PR# 24164: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24164: 502 Server Error []
github.go:428] Error getting PR# 24164: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24164: 502 Server Error []
github.go:1074] Error commits for PR 24164: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24164/commits?per_page=100: 502 Server Error []
github.go:428] Error getting PR# 24164: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24164: 502 Server Error []
github.go:428] Error getting PR# 24164: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24164: 502 Server Error []
github.go:428] Error getting PR# 24164: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24164: 502 Server Error []
github.go:428] Error getting PR# 24164: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24164: 502 Server Error []
github.go:1074] Error commits for PR 24549: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24549/commits?per_page=100: 502 Server Error []
lgtm_after_commit.go:73] PR 24549 unable to determine lastModified or lgtmTime
github.go:428] Error getting PR# 24549: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24549: 502 Server Error []
github.go:428] Error getting PR# 24549: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24549: 502 Server Error []
github.go:627] Adding labels [do-not-merge] to PR 24549
github.go:1327] Commenting "This PR is not for the master branch but does not have the `cherrypick-approved` label. Adding the `do-not-merge` label." in 24549
github.go:428] Error getting PR# 24549: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24549: 502 Server Error []
github.go:428] Error getting PR# 24549: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24549: 502 Server Error []
github.go:1074] Error commits for PR 24549: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24549/commits?per_page=100: 502 Server Error []
github.go:428] Error getting PR# 24549: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24549: 502 Server Error []
github.go:428] Error getting PR# 24549: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24549: 502 Server Error []
github.go:428] Error getting PR# 24549: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24549: 502 Server Error []
github.go:428] Error getting PR# 24549: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24549: 502 Server Error []
github.go:428] Error getting PR# 24549: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24549: 502 Server Error []
submit-queue.go:678] 24549: unknown err: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24549: 502 Server Error []
github.go:428] Error getting PR# 24549: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24549: 502 Server Error []
github.go:428] Error getting PR# 24549: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24549: 502 Server Error []
github.go:428] Error getting PR# 24549: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24549: 502 Server Error []
github.go:428] Error getting PR# 24554: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24554: 502 Server Error []
github.go:428] Error getting PR# 24554: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24554: 502 Server Error []
github.go:627] Adding labels [do-not-merge] to PR 24554
github.go:1327] Commenting "This PR is not for the master branch but does not have the `cherrypick-approved` label. Adding the `do-not-merge` label." in 24554
github.go:428] Error getting PR# 24554: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24554: 502 Server Error []
github.go:1074] Error commits for PR 24554: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24554/commits?per_page=100: 502 Server Error []
github.go:428] Error getting PR# 24554: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24554: 502 Server Error []
github.go:428] Error getting PR# 24554: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24554: 502 Server Error []
github.go:428] Error getting PR# 24554: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24554: 502 Server Error []
submit-queue.go:678] 24554: unknown err: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24554: 502 Server Error []
github.go:428] Error getting PR# 24554: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24554: 502 Server Error []
github.go:428] Error getting PR# 24554: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24554: 502 Server Error []
github.go:428] Error getting PR# 24554: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24554: 502 Server Error []
github.go:428] Error getting PR# 24557: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24557: 502 Server Error []
github.go:428] Error getting PR# 24710: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24710: 502 Server Error []
github.go:428] Error getting PR# 24710: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24710: 502 Server Error []
github.go:627] Adding labels [do-not-merge] to PR 24710
github.go:1327] Commenting "This PR is not for the master branch but does not have the `cherrypick-approved` label. Adding the `do-not-merge` label." in 24710
github.go:428] Error getting PR# 24710: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24710: 502 Server Error []
github.go:1074] Error commits for PR 24710: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24710/commits?per_page=100: 502 Server Error []
github.go:428] Error getting PR# 24710: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24710: 502 Server Error []
github.go:428] Error getting PR# 24710: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24710: 502 Server Error []
submit-queue.go:678] 24710: unknown err: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24710: 502 Server Error []
github.go:428] Error getting PR# 24710: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24710: 502 Server Error []
github.go:428] Error getting PR# 24710: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24710: 502 Server Error []
github.go:428] Error getting PR# 24710: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24710: 502 Server Error []
github.go:428] Error getting PR# 24718: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24718: 502 Server Error []
github.go:428] Error getting PR# 24718: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24718: 502 Server Error []
github.go:627] Adding labels [do-not-merge] to PR 24718
github.go:1327] Commenting "This PR is not for the master branch but does not have the `cherrypick-approved` label. Adding the `do-not-merge` label." in 24718
github.go:428] Error getting PR# 24718: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24718: 502 Server Error []
github.go:1074] Error commits for PR 24718: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24718/commits?per_page=100: 502 Server Error []
github.go:428] Error getting PR# 24718: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24718: 502 Server Error []
github.go:428] Error getting PR# 24718: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24718: 502 Server Error []
github.go:428] Error getting PR# 24718: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24718: 502 Server Error []
submit-queue.go:678] 24718: unknown err: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24718: 502 Server Error []
github.go:428] Error getting PR# 24718: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24718: 502 Server Error []
github.go:428] Error getting PR# 24718: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24718: 502 Server Error []
github.go:929] PR 24718 setting "Submit Queue" Github status to "unknown failure"
github.go:428] Error getting PR# 24835: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24835: 502 Server Error []
github.go:428] Error getting PR# 24835: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24835: 502 Server Error []
github.go:627] Adding labels [do-not-merge] to PR 24835
github.go:1327] Commenting "This PR is not for the master branch but does not have the `cherrypick-approved` label. Adding the `do-not-merge` label." in 24835
github.go:428] Error getting PR# 24835: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24835: 502 Server Error []
github.go:1074] Error commits for PR 24835: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24835/commits?per_page=100: 502 Server Error []
github.go:428] Error getting PR# 24835: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24835: 502 Server Error []
github.go:428] Error getting PR# 24835: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24835: 502 Server Error []
github.go:428] Error getting PR# 24835: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24835: 502 Server Error []
submit-queue.go:678] 24835: unknown err: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24835: 502 Server Error []
github.go:428] Error getting PR# 24835: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24835: 502 Server Error []
github.go:428] Error getting PR# 24835: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24835: 502 Server Error []
github.go:428] Error getting PR# 24835: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24835: 502 Server Error []
github.go:428] Error getting PR# 24836: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24836: 502 Server Error []
github.go:428] Error getting PR# 24836: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24836: 502 Server Error []
github.go:627] Adding labels [do-not-merge] to PR 24836
github.go:1327] Commenting "This PR is not for the master branch but does not have the `cherrypick-approved` label. Adding the `do-not-merge` label." in 24836
github.go:428] Error getting PR# 24836: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24836: 502 Server Error []
github.go:1074] Error commits for PR 24836: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24836/commits?per_page=100: 502 Server Error []
github.go:428] Error getting PR# 24836: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24836: 502 Server Error []
github.go:428] Error getting PR# 24836: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24836: 502 Server Error []
github.go:428] Error getting PR# 24836: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24836: 502 Server Error []
submit-queue.go:678] 24836: unknown err: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24836: 502 Server Error []
github.go:428] Error getting PR# 24836: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24836: 502 Server Error []
github.go:428] Error getting PR# 24836: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24836: 502 Server Error []
github.go:428] Error getting PR# 24836: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24836: 502 Server Error []
github.go:428] Error getting PR# 24838: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24838: 502 Server Error []
github.go:428] Error getting PR# 24838: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24838: 502 Server Error []
github.go:627] Adding labels [do-not-merge] to PR 24838
github.go:1327] Commenting "This PR is not for the master branch but does not have the `cherrypick-approved` label. Adding the `do-not-merge` label." in 24838
github.go:428] Error getting PR# 24838: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24838: 502 Server Error []
github.go:1074] Error commits for PR 24838: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24838/commits?per_page=100: 502 Server Error []
github.go:428] Error getting PR# 24838: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24838: 502 Server Error []
github.go:428] Error getting PR# 24838: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24838: 502 Server Error []
submit-queue.go:678] 24838: unknown err: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24838: 502 Server Error []
github.go:428] Error getting PR# 24838: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24838: 502 Server Error []
github.go:428] Error getting PR# 24838: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24838: 502 Server Error []
github.go:428] Error getting PR# 24838: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24838: 502 Server Error []
github.go:428] Error getting PR# 24841: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24841: 502 Server Error []
github.go:428] Error getting PR# 24841: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24841: 502 Server Error []
github.go:627] Adding labels [do-not-merge] to PR 24841
github.go:1327] Commenting "This PR is not for the master branch but does not have the `cherrypick-approved` label. Adding the `do-not-merge` label." in 24841
github.go:428] Error getting PR# 24841: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24841: 502 Server Error []
github.go:1074] Error commits for PR 24841: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24841/commits?per_page=100: 502 Server Error []
blunderbuss.go:125] Couldn't find an owner for: .gitignore
blunderbuss.go:137] No owners found for PR 24897
github.go:1074] Error commits for PR 24921: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24921/commits?per_page=100: 502 Server Error []
github.go:1074] Error commits for PR 24921: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24921/commits?per_page=100: 502 Server Error []
github.go:1074] Error commits for PR 24921: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24921/commits?per_page=100: 502 Server Error []
github.go:428] Error getting PR# 24923: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24923: 502 Server Error []
github.go:428] Error getting PR# 24923: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24923: 502 Server Error []
github.go:627] Adding labels [do-not-merge] to PR 24923
github.go:1327] Commenting "This PR is not for the master branch but does not have the `cherrypick-approved` label. Adding the `do-not-merge` label." in 24923
github.go:428] Error getting PR# 24923: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24923: 502 Server Error []
github.go:1074] Error commits for PR 24923: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24923/commits?per_page=100: 502 Server Error []
github.go:428] Error getting PR# 24923: GET https://api.github.com/repos/kubernetes/kubernetes/pulls/24923: 502 Server Error []
blunderbuss.go:156] Assigning 24961 to mikedanese who had a 24.14% chance to be assigned (previously assigned to <nil>)
github.go:1124] Assigning PR# 24961  to mikedanese
github.go:627] Adding labels [size/L] to PR 24961
github.go:1327] Commenting "Labelling this PR as size/L" in 24961
github.go:627] Adding labels [release-note-label-needed] to PR 24961
github.go:929] PR 24961 setting "Submit Queue" Github status to "Github CI tests are not green."
github.go:217] Made 4123 API calls since the last Reset 2.663085 calls/sec
mungegithub.go:77] Not sleeping as we took more than 10m0s to complete one loop

Copied from original issue: kubernetes-retired/contrib#867
@foxish
Copy link
Contributor Author

foxish commented Jan 21, 2017

From @eparis on April 29, 2016 12:40

Once you cut out the cruft above this was the misbehavior

lgtm_after_commit.go:73] PR 24164 unable to determine lastModified or lgtmTime
github.go:627] Adding labels [do-not-merge] to PR 24164
github.go:1327] Commenting "This PR is not for the master branch but does not have the `cherrypick-approved` label. Adding the `do-not-merge` label." in 24164
lgtm_after_commit.go:73] PR 24549 unable to determine lastModified or lgtmTime
github.go:627] Adding labels [do-not-merge] to PR 24549
github.go:1327] Commenting "This PR is not for the master branch but does not have the `cherrypick-approved` label. Adding the `do-not-merge` label." in 24549
github.go:627] Adding labels [do-not-merge] to PR 24554
github.go:1327] Commenting "This PR is not for the master branch but does not have the `cherrypick-approved` label. Adding the `do-not-merge` label." in 24554
github.go:627] Adding labels [do-not-merge] to PR 24710
github.go:1327] Commenting "This PR is not for the master branch but does not have the `cherrypick-approved` label. Adding the `do-not-merge` label." in 24710
github.go:627] Adding labels [do-not-merge] to PR 24718
github.go:1327] Commenting "This PR is not for the master branch but does not have the `cherrypick-approved` label. Adding the `do-not-merge` label." in 24718
github.go:929] PR 24718 setting "Submit Queue" Github status to "unknown failure"
github.go:627] Adding labels [do-not-merge] to PR 24835
github.go:1327] Commenting "This PR is not for the master branch but does not have the `cherrypick-approved` label. Adding the `do-not-merge` label." in 24835
github.go:627] Adding labels [do-not-merge] to PR 24836
github.go:1327] Commenting "This PR is not for the master branch but does not have the `cherrypick-approved` label. Adding the `do-not-merge` label." in 24836
github.go:627] Adding labels [do-not-merge] to PR 24838
github.go:1327] Commenting "This PR is not for the master branch but does not have the `cherrypick-approved` label. Adding the `do-not-merge` label." in 24838
github.go:627] Adding labels [do-not-merge] to PR 24841
github.go:1327] Commenting "This PR is not for the master branch but does not have the `cherrypick-approved` label. Adding the `do-not-merge` label." in 24841
blunderbuss.go:125] Couldn't find an owner for: .gitignore
blunderbuss.go:137] No owners found for PR 24897
github.go:627] Adding labels [do-not-merge] to PR 24923
github.go:1327] Commenting "This PR is not for the master branch but does not have the `cherrypick-approved` label. Adding the `do-not-merge` label." in 24923
blunderbuss.go:156] Assigning 24961 to mikedanese who had a 24.14% chance to be assigned (previously assigned to <nil>)
github.go:1124] Assigning PR# 24961  to mikedanese
github.go:627] Adding labels [size/L] to PR 24961
github.go:1327] Commenting "Labelling this PR as size/L" in 24961
github.go:627] Adding labels [release-note-label-needed] to PR 24961
github.go:929] PR 24961 setting "Submit Queue" Github status to "Github CI tests are not green."
github.go:217] Made 4123 API calls since the last Reset 2.663085 calls/sec
mungegithub.go:77] Not sleeping as we took more than 10m0s to complete one loop

@foxish
Copy link
Contributor Author

foxish commented Jan 21, 2017

From @eparis on April 29, 2016 12:42

Looks like just these got messed up:
kubernetes/kubernetes#24164
kubernetes/kubernetes#24549
kubernetes/kubernetes#24554
kubernetes/kubernetes#24710
kubernetes/kubernetes#24718
kubernetes/kubernetes#24835
kubernetes/kubernetes#24836
kubernetes/kubernetes#24838
kubernetes/kubernetes#24841
kubernetes/kubernetes#24923

@foxish foxish mentioned this issue Jan 21, 2017
Closed
@fejta fejta closed this as completed May 17, 2017
grantr pushed a commit to grantr/test-infra that referenced this issue Feb 21, 2020
@chizhg @knative-prow-robot
ProwAutoBumper also updates images for boskos (kubernetes#1628)
dfeb254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@foxish @fejta