Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final draft for v1.31 release #2579

Merged

Conversation

npolshakova
Copy link
Contributor

@npolshakova npolshakova commented Jul 31, 2024

What type of PR is this:
/kind cleanup
/kind documentation

What this PR does / why we need it:

This PR refactors and fine-tunes all the release-notes for v1.31.0, and does the following:

  • Cleanups up md file
  • Cleans up the json files to make sure the website has the revised release notes

The major themes link to the upcoming release article will not be included as we are moving away from having major themes being a thing in future releases.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Jul 31, 2024
@k8s-ci-robot k8s-ci-robot added area/release-team Issues or PRs related to the release-team subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 31, 2024
saschagrunert

This comment was marked as outdated.

Copy link

@everpeace everpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I'm KEP-3619 owner. May I add this release note item

- Added Node.Status.Features.SupplementalGroupsPolicy field which is set to true when the feature is implemented in the CRI implementation (KEP-3619) ([#125470](https://github.com/kubernetes/kubernetes/pull/125470), [@everpeace](https://github.com/everpeace)) [SIG API Machinery, Apps, Node and Testing]

next to L.64?

- Support fine-grained supplemental groups policy (KEP-3619), which enables fine-grained control for supplementary groups in the first container processes. You can choose whether to include groups defined in the container image(/etc/groups) for the container's primary uid or not. ([#117842](https://github.com/kubernetes/kubernetes/pull/117842), [@everpeace](https://github.com/everpeace)) [SIG API Machinery, Apps and Node]

This item is user-facing which is related to KEP-3619. And, this item is actually included in rc.0 release note: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.31.md?plain=1#L186

@jsafrane
Copy link
Member

jsafrane commented Aug 5, 2024

Would it be possible to re-generate release note / add it manually from kubernetes/kubernetes#124815? I added release-note field there today.

It could be one of the "Urgent Upgrade Notes". Chance that someone has the removed feature gates enabled is very low, but if they do, then they need to remove them from cmdline of all Kubernetes components.

I am adding a note to the release blog here: https://github.com/kubernetes/website/pull/47281/files#r1703842605

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2024
@npolshakova npolshakova force-pushed the npolshak/final-release-notes-draft branch from b3f1422 to cacf61d Compare August 7, 2024 13:31
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 7, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@npolshakova npolshakova force-pushed the npolshak/final-release-notes-draft branch from cacf61d to 84a8799 Compare August 12, 2024 13:41
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2024
@k8s-ci-robot k8s-ci-robot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 12, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 12, 2024
@npolshakova npolshakova requested a review from cloudmelon August 12, 2024 13:55
@npolshakova npolshakova force-pushed the npolshak/final-release-notes-draft branch 2 times, most recently from 4e7c24b to 30c9a3c Compare August 12, 2024 14:24
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 12, 2024
@npolshakova npolshakova force-pushed the npolshak/final-release-notes-draft branch from 30c9a3c to 96187af Compare August 12, 2024 14:33
@npolshakova npolshakova force-pushed the npolshak/final-release-notes-draft branch 3 times, most recently from 0fd7467 to a72675b Compare August 12, 2024 21:03
@npolshakova npolshakova force-pushed the npolshak/final-release-notes-draft branch from a72675b to 66025a0 Compare August 13, 2024 12:51
@neoaggelos
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neoaggelos, npolshakova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit df56ae4 into kubernetes:master Aug 13, 2024
2 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Aug 13, 2024
@npolshakova npolshakova deleted the npolshak/final-release-notes-draft branch September 17, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants