Update release notes draft to version v1.30.0-alpha.3 #2449

npolshakova · 2024-03-06T18:28:00Z

What type of PR is this?
/kind documentation

What this PR does / why we need it:
This PR updates the Release Notes Draft to k/k v1.30.0-alpha.3

Which issue(s) this PR fixes:

Special notes for your reviewer:
This is an automated PR generated from krel The Kubernetes Release Toolbox

releases/release-1.30/release-notes/maps/pr-122293-map.yaml

releases/release-1.30/release-notes/maps/pr-123023-map.yaml

fykaa

Just a few things to note regarding empty release notes: we can write a note with the help of the PR, or simply state "none" if it's empty. Other than that, all the notes looks good to me!

releases/release-1.30/release-notes/maps/pr-118389-map.yaml

releases/release-1.30/release-notes/maps/pr-118756-map.yaml

releases/release-1.30/release-notes/release-notes-draft.json

rashansmith

@npolshakova Looking good so far! Just a few more suggestions!

releases/release-1.30/release-notes/maps/pr-119923-map.yaml

releases/release-1.30/release-notes/maps/pr-120642-map.yaml

releases/release-1.30/release-notes/maps/pr-120902-map.yaml

releases/release-1.30/release-notes/maps/pr-121669-map.yaml

rashansmith · 2024-03-08T20:55:16Z

/approve

rashansmith · 2024-03-08T20:57:08Z

/lgtm
/assign @ramrodo

ramrodo

Thanks for this PR!

Just a suggestion related to the NONE files. Please remove/delete them.

ramrodo · 2024-03-12T13:46:06Z

releases/release-1.30/release-notes/maps/pr-118389-map.yaml

Please remove this file as its release note is NONE.

Should be removed! Should we update the release-notes-draft.json as well?

Yes, remove them from the release-notes-draft.json also.

@ramrodo can you confirm?

So do we want to leave the original text, and empty string or "NONE" in the json file? #2449 (comment)

Do not keep the original text nor the NONE string, maybe remove it all.

Do we want to remove all the NONE release notes from the release-notes-draft.json? Or just the ones with the extra text? For example, there are PRs like 120631 already on master: https://github.com/kubernetes/sig-release/blob/master/releases/release-1.30/release-notes/release-notes-draft.json#L263

@ramrodo Just want to make sure it's fine to keep 120631, 122569, 122692, 123051, 123438, 123488, 123490 in.

It looks like prior release have the NONE string: https://github.com/kubernetes/sig-release/blob/master/releases/release-1.25/release-notes/release-notes-draft.json#L517

But the weird parsing from the release notes collector looks like it's a new bug that has only happened in 1.29 and 1.30:

sig-release/releases/release-1.29/release-notes/release-notes-draft.json

Line 374 in 34a6a6c

"text": "```\n\n#### Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:\n\n\u003c!--\nThis section can be blank if this pull request does not require a release note.\n\nWhen adding links which point to resources within git repositories, like\nKEPs or supporting documentation, please reference a specific commit and avoid\nlinking directly to the master branch. This ensures that links reference a\nspecific point in time, rather than a document that may change over time.\n\nSee here for guidance on getting permanent links to files: https://help.github.com/en/articles/getting-permanent-links-to-files\n\nPlease use the following format for linking documentation:\n- [KEP]: \u003clink\u003e\n- [Usage]: \u003clink\u003e\n- [Other doc]: \u003clink\u003e\n--\u003e",

npolshakova · 2024-03-12T18:18:33Z

releases/release-1.30/release-notes/release-notes-draft.json

@@ -87,8 +180,8 @@
  },
  "118389": {
    "commit": "be77b0b82b01a3fc810118f095594ec8bdd3c3aa",
-    "text": "```\n\n#### Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:\n\n\u003c!--\nThis section can be blank if this pull request does not require a release note.\n\nWhen adding links which point to resources within git repositories, like\nKEPs or supporting documentation, please reference a specific commit and avoid\nlinking directly to the master branch. This ensures that links reference a\nspecific point in time, rather than a document that may change over time.\n\nSee here for guidance on getting permanent links to files: https://help.github.com/en/articles/getting-permanent-links-to-files\n\nPlease use the following format for linking documentation:\n- [KEP]: \u003clink\u003e\n- [Usage]: \u003clink\u003e\n- [Other doc]: \u003clink\u003e\n--\u003e",


If this PR had the /release-note-none label, where is the text here coming from?

I wonder if this happens when the release note block in the PR is left empty instead of adding "NONE" as requested in the instructions, or when they add it in the wrong place. For example: kubernetes/kubernetes#121565

This is probably a bug. We can remove this text (as you did) for now and submit an issue to kubernetes/release repo for debugging and fixing this (if it applies).

kubernetes/release#3516

rashansmith · 2024-03-18T19:29:38Z

releases/release-1.30/release-notes/release-notes-draft.json

@@ -1598,6 +1864,22 @@
    ],
    "duplicate": true
  },
+  "122569": {


@npolshakova PRs like this should be removed

rashansmith

/lgtm

rashansmith · 2024-03-18T19:55:10Z

/assign @ramrodo

ramrodo

I think this PR is enough good for now. Let's merge this PR and we can submit another if we need to fix any missing NONE string later.
Thanks for the hard work and the patience.

/lgtm
/approve

k8s-ci-robot · 2024-03-18T20:28:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: npolshakova, ramrodo, rashansmith

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~releases/release-1.30/OWNERS~~ [ramrodo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 6, 2024

k8s-ci-robot requested review from rashansmith and salehsedghpour March 6, 2024 18:28

k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 6, 2024

npolshakova force-pushed the release-notes-draft-v1.30.0-alpha.3 branch 2 times, most recently from ca56d8b to 65a85a0 Compare March 6, 2024 18:39

rashansmith reviewed Mar 6, 2024

View reviewed changes

releases/release-1.30/release-notes/maps/pr-122293-map.yaml Outdated Show resolved Hide resolved

rashansmith reviewed Mar 6, 2024

View reviewed changes

releases/release-1.30/release-notes/maps/pr-123023-map.yaml Outdated Show resolved Hide resolved

fykaa reviewed Mar 8, 2024

View reviewed changes

releases/release-1.30/release-notes/maps/pr-118389-map.yaml Outdated Show resolved Hide resolved

releases/release-1.30/release-notes/maps/pr-118756-map.yaml Outdated Show resolved Hide resolved

npolshakova force-pushed the release-notes-draft-v1.30.0-alpha.3 branch from 65a85a0 to 19d363f Compare March 8, 2024 19:08

npolshakova commented Mar 8, 2024

View reviewed changes

releases/release-1.30/release-notes/release-notes-draft.json Show resolved Hide resolved

npolshakova force-pushed the release-notes-draft-v1.30.0-alpha.3 branch from 19d363f to 21498e2 Compare March 8, 2024 19:15

rashansmith reviewed Mar 8, 2024

View reviewed changes

npolshakova force-pushed the release-notes-draft-v1.30.0-alpha.3 branch 2 times, most recently from ad4ae1f to bbc7e8d Compare March 8, 2024 20:45

k8s-ci-robot assigned ramrodo and rashansmith Mar 8, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2024

ramrodo suggested changes Mar 12, 2024

View reviewed changes

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2024

npolshakova commented Mar 12, 2024

View reviewed changes

npolshakova force-pushed the release-notes-draft-v1.30.0-alpha.3 branch from bbc7e8d to 2ee1a97 Compare March 13, 2024 14:20

npolshakova requested a review from ramrodo March 14, 2024 13:35

npolshakova mentioned this pull request Mar 18, 2024

Release Notes Collection Picks Up Incorrect Text kubernetes/release#3516

Closed

npolshakova force-pushed the release-notes-draft-v1.30.0-alpha.3 branch from 2ee1a97 to 5922704 Compare March 18, 2024 19:20

npolshakova requested a review from rashansmith March 18, 2024 19:20

rashansmith reviewed Mar 18, 2024

View reviewed changes

Release Notes draft for k/k v1.30.0-alpha.3

3cc6fc8

npolshakova force-pushed the release-notes-draft-v1.30.0-alpha.3 branch from 5922704 to 3cc6fc8 Compare March 18, 2024 19:44

rashansmith approved these changes Mar 18, 2024

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2024

ramrodo approved these changes Mar 18, 2024

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2024

ramrodo merged commit 3e30b8c into kubernetes:master Mar 18, 2024
2 checks passed

k8s-ci-robot added this to the v1.30 milestone Mar 18, 2024

npolshakova mentioned this pull request Sep 17, 2024

Fix empty release note parsing kubernetes/release#3764

Merged

npolshakova deleted the release-notes-draft-v1.30.0-alpha.3 branch September 17, 2024 13:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update release notes draft to version v1.30.0-alpha.3 #2449

Update release notes draft to version v1.30.0-alpha.3 #2449

npolshakova commented Mar 6, 2024

fykaa left a comment

rashansmith left a comment

rashansmith commented Mar 8, 2024

rashansmith commented Mar 8, 2024

ramrodo left a comment

ramrodo Mar 12, 2024

npolshakova Mar 13, 2024

ramrodo Mar 13, 2024

rashansmith Mar 13, 2024

npolshakova Mar 13, 2024

ramrodo Mar 16, 2024 •

edited

Loading

npolshakova Mar 18, 2024

npolshakova Mar 18, 2024

npolshakova Mar 12, 2024

rashansmith Mar 13, 2024

ramrodo Mar 13, 2024

npolshakova Mar 18, 2024

rashansmith Mar 18, 2024

rashansmith left a comment

rashansmith commented Mar 18, 2024

ramrodo left a comment

k8s-ci-robot commented Mar 18, 2024

Update release notes draft to version v1.30.0-alpha.3 #2449

Update release notes draft to version v1.30.0-alpha.3 #2449

Conversation

npolshakova commented Mar 6, 2024

fykaa left a comment

Choose a reason for hiding this comment

rashansmith left a comment

Choose a reason for hiding this comment

rashansmith commented Mar 8, 2024

rashansmith commented Mar 8, 2024

ramrodo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ramrodo Mar 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rashansmith left a comment

Choose a reason for hiding this comment

rashansmith commented Mar 18, 2024

ramrodo left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Mar 18, 2024

ramrodo Mar 16, 2024 •

edited

Loading