Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue template: add note about krel-fast forward #2124

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

saschagrunert
Copy link
Member

What type of PR is this:

/kind documentation

What this PR does / why we need it:

We now add a note about how krel fast-forward behaves when cutting v1.x.0 releases.

Which issue(s) this PR fixes:

Refers to kubernetes/release#2807

Special notes for your reviewer:

PTAL @kubernetes/release-managers

We now add a note about how `krel fast-forward` behaves when cutting
v1.x.0 releases.

Signed-off-by: Sascha Grunert <[email protected]>
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. needs-priority labels Dec 13, 2022
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 13, 2022
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2022
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@xmudrii
Copy link
Member

xmudrii commented Dec 13, 2022

/test all

@k8s-ci-robot
Copy link
Contributor

@xmudrii: No presubmit jobs available for kubernetes/sig-release@master

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member

xmudrii commented Dec 13, 2022

/check-cla

@xmudrii
Copy link
Member

xmudrii commented Dec 13, 2022

/close

@xmudrii xmudrii closed this Dec 13, 2022
@xmudrii xmudrii reopened this Dec 13, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9f747ac into kubernetes:master Dec 13, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Dec 13, 2022
@saschagrunert saschagrunert deleted the release-cut-note branch December 13, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants