Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update priority link in Bug-Triage Handbook #1398

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Update priority link in Bug-Triage Handbook #1398

merged 1 commit into from
Dec 21, 2020

Conversation

ramrodo
Copy link
Member

@ramrodo ramrodo commented Dec 21, 2020

This change updates the link of "the documentation for defining priority and priority labels" to the right one.

related to #1324

Signed-off-by: Rodolfo Martínez Vega [email protected]

What type of PR is this:

/kind documentation

What this PR does / why we need it:

Since the 1.21 Release Team Shadow Application is started, some Shadow candidates are reading these docs and should be referenced to the right information.

Which issue(s) this PR fixes:

Relevant to #1324

@ramrodo
Update priority link in Bug-Triage Handbook
c3db735 
This change updates the link of "the documentation for defining priority and `priority` labels" to the right one.

related to kubernetes#1324

Signed-off-by: Rodolfo Martínez Vega <[email protected]>
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Dec 21, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @ramrodo!

It looks like this is your first PR to kubernetes/sig-release 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/sig-release has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/release-team Issues or PRs related to the release-team subproject labels Dec 21, 2020
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Dec 21, 2020
hasheddan
hasheddan approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ramrodo!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, ramrodo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7a5b342 into kubernetes:master Dec 21, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Dec 21, 2020
@ramrodo ramrodo mentioned this pull request Apr 27, 2021
Closed
6 tasks
@ramrodo ramrodo mentioned this pull request May 31, 2022
Closed
9 tasks
@ramrodo ramrodo deleted the gh-1324-update-bug-triage-handbook-priority-link branch June 2, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@josiahbjorgaard josiahbjorgaard Awaiting requested review from josiahbjorgaard

@smourapina smourapina Awaiting requested review from smourapina

Assignees

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
3 participants
@ramrodo @k8s-ci-robot @hasheddan