Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for k8s-stable4 version marker #2094

Closed
xmudrii opened this issue Nov 9, 2022 · 10 comments
Closed

Add support for k8s-stable4 version marker #2094

xmudrii opened this issue Nov 9, 2022 · 10 comments
Assignees
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@xmudrii
Copy link
Member

xmudrii commented Nov 9, 2022

What would you like to be added:

We should add support for the k8s-stable4 version marker because it might happen that we support 4 branches in parallel.

(Part of #850.)

Why is this needed:

We had a problem that we supported 1.25, 1.24, 1.23, and 1.22 at the same time. In this case, both ci-kubernetes-build-1.23 and ci-kubernetes-build-1.22 pointed to the k8s-stable3 version marker. This might cause issues with tests or produce test results that are not reliable because the same k8s-stable3 version marker is getting changed by two different jobs for two different release branches.

We mitigated this manually by adding the k8s-stable4 version marker in kubernetes/test-infra#27945, but we'll mostly like end up with the same problem again once 1.26 is out. That being said, we might need to modify config-rotator and update docs.

@xmudrii xmudrii added kind/feature Categorizes issue or PR as related to a new feature. sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels Nov 9, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Nov 9, 2022

Alternatively, considering that those k8s-stable version markers are deprecated, we should check if those jobs can switch to the new release markers.

@justaugustus justaugustus transferred this issue from kubernetes/release Nov 22, 2022
@justaugustus
Copy link
Member

(transferred this to k/sig-release)

@justaugustus
Copy link
Member

/assign @xmudrii

@xmudrii
Copy link
Member Author

xmudrii commented Nov 24, 2022

@justaugustus I would consider this done since we support the stable4 marker and there are jobs using it. Do you think it's okay to close this issue or is there anything I forgot about?

@xmudrii xmudrii added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 25, 2022
@justaugustus
Copy link
Member

Do you think it's okay to close this issue or is there anything I forgot about?

Let's wait until kubernetes/test-infra#28119 merges. :)

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 28, 2023
@xmudrii
Copy link
Member Author

xmudrii commented Feb 28, 2023

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 28, 2023
@xmudrii
Copy link
Member Author

xmudrii commented Mar 23, 2023

We have full support for the stable4 version marker with kubernetes/test-infra#29098. It's also documented here: https://github.com/kubernetes/community/blob/ad1bca23543ed0adc27c2ce7935454b0b7be9b12/contributors/devel/sig-release/kubernetes-versions.md?plain=1#L331

With that, I'm going to close this issue.
/close

@k8s-ci-robot
Copy link
Contributor

@xmudrii: Closing this issue.

In response to this:

We have full support for the stable4 version marker with kubernetes/test-infra#29098. It's also documented here: https://github.com/kubernetes/community/blob/ad1bca23543ed0adc27c2ce7935454b0b7be9b12/contributors/devel/sig-release/kubernetes-versions.md?plain=1#L331

With that, I'm going to close this issue.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

5 participants