if the file is a generated and does not have date stop the checks

[cpanato]

in a generated go file that does not have the date the current boilerplate is failing, because it tries to find a date where does not exist.

if is a generated file and passes in the check for that we should return and not perform the year validation

/assign @saschagrunert @justaugustus

[cpanato]

if agree we will need a new release to be able to use in release-sdk/utils

[cpanato]

need in this pr: kubernetes-sigs/release-sdk#25

tested the change in that pr as well

[justaugustus]

Thanks @cpanato!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [justaugustus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[justaugustus]

Something to consider: #248

[edwarnicke]

Out of curiosity... are you checking for copyrights in generated files? I ask, because typically I tend to think of copyright checks as linting, and linters aren't supposed to lint generated files. Typically linters don't lint generated files, detecting that they are generated by looking for the pattern at the top of generated files:

^// Code generated .* DO NOT EDIT\.$

Per https://pkg.go.dev/cmd/go#hdr-Generate_Go_files_by_processing_source

[justaugustus]

Out of curiosity... are you checking for copyrights in generated files? I ask, because typically I tend to think of copyright checks as linting, and linters aren't supposed to lint generated files. Typically linters don't lint generated files, detecting that they are generated by looking for the pattern at the top of generated files:

^// Code generated .* DO NOT EDIT\.$

Per https://pkg.go.dev/cmd/go#hdr-Generate_Go_files_by_processing_source

We do indeed!

repo-infra/hack/verify_boilerplate.py

Lines 79 to 83 in 201dcad

	# given the file contents, return true if the file appears to be generated
	def is_generated(data):
	if re.search(r"^// Code generated by .*\. DO NOT EDIT\.$", data, re.MULTILINE):
	return True
	return False

Though there may be some duplicative logic:

repo-infra/hack/verify_boilerplate.py

Lines 156 to 158 in 201dcad

	# even when generated by bazel we will complain about some generated files
	# not having the headers. since they're just generated, ignore them
	IGNORE_HEADERS = ['// Code generated by go-bindata.']