Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rules_go: update to use go1.15.13 #241

Merged
merged 1 commit into from
Jun 9, 2021
Merged

rules_go: update to use go1.15.13 #241

merged 1 commit into from
Jun 9, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jun 8, 2021

Needed for go1.15.13 update: kubernetes/release#2107

  • update sdks versions to have go1.15.13 information
    to check the hashes can validate in this page: https://golang.org/dl/

/assign @justaugustus @saschagrunert @fejta @mikedanese @thejoycekung
cc: @kubernetes/release-engineering

after the merge, we will need to tag a new v0.1.x release

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 8, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jun 8, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2021
justaugustus
justaugustus approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit a56f719 into kubernetes:release-0.1 Jun 9, 2021
@cpanato cpanato deleted the go11513 branch June 9, 2021 14:16
@cpanato cpanato mentioned this pull request Jun 9, 2021
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@justaugustus justaugustus justaugustus approved these changes

@mikedanese mikedanese Awaiting requested review from mikedanese

@Verolop Verolop Awaiting requested review from Verolop

Assignees

@justaugustus justaugustus

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cpanato @k8s-ci-robot @justaugustus @saschagrunert