Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/release: Skip attempts to set GCS object policy on new buckets #907

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

justaugustus
Copy link
Member

New Kubernetes infra buckets, like k8s-staging-release-test, have a
bucket-only ACL policy set, which means attempting to set the ACL on an
object will fail. We should skip this ACL change in those instances, as
new buckets already default to being publicly readable.

(There will likely by other places to fix this in the future, but I'd like to do this incrementally to make sure we investigate any permissions errors.)

Ref: https://cloud.google.com/storage/docs/bucket-policy-only
Fixes: #904

Signed-off-by: Stephen Augustus [email protected]

/assign @dims @thockin @tpepper
cc: @kubernetes/release-engineering
/milestone v1.17
/priority important-soon
/kind bug

New Kubernetes infra buckets, like k8s-staging-release-test, have a
bucket-only ACL policy set, which means attempting to set the ACL on an
object will fail. We should skip this ACL change in those instances, as
new buckets already default to being publicly readable.

Ref: https://cloud.google.com/storage/docs/bucket-policy-only

Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot added do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Oct 24, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 24, 2019
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 24, 2019
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Oct 24, 2019
@justaugustus justaugustus removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Oct 24, 2019
@dims
Copy link
Member

dims commented Oct 24, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b220a83 into kubernetes:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prow deployer account needs permission to set storage object ACLs on k8s-staging-release-test GCP
5 participants