lib/release: Skip attempts to set GCS object policy on new buckets #907
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Kubernetes infra buckets, like k8s-staging-release-test, have a
bucket-only ACL policy set, which means attempting to set the ACL on an
object will fail. We should skip this ACL change in those instances, as
new buckets already default to being publicly readable.
(There will likely by other places to fix this in the future, but I'd like to do this incrementally to make sure we investigate any permissions errors.)
Ref: https://cloud.google.com/storage/docs/bucket-policy-only
Fixes: #904
Signed-off-by: Stephen Augustus [email protected]
/assign @dims @thockin @tpepper
cc: @kubernetes/release-engineering
/milestone v1.17
/priority important-soon
/kind bug