Update debian/ubuntu build definitions

[justaugustus]

• Update symlinks for all debian-like package definitions
• Update debian/ubuntu versions to use a single distro variable
• Remove build definitions for unsupported versions of Debian & Ubuntu

Signed-off-by: Stephen Augustus [email protected]

[spiffxp]

/hold
this looks sane, but merits some explanation

when we say EOL, what are we referring to here? EOL according to this project's policies, or the distro's policies? is there a link for this decision? etc.

would like someone from patch release team to review (ie: @tpepper who is assigned) and /hold cancel at their discretion

[spiffxp]

/assign @tpepper
I mean, is assigned now

[justaugustus]

@spiffxp -- I'm thinking OS EOL here.
I think that we should only build for distro versions that are in support.
I'm not sure that we have a policy around that currently, but you're right, AFAIK, this hasn't been discussed widely or documented, so let's consider this the start of that discussion.

The addition of bionic to the list (#719) was the inspiration for this.
My only additional thought here is that it'd be nice to get this in before we cut the 1.15.0 release.

[justaugustus]

Updated this PR to include collapsing debian-like allDistros, serverDistros var into distros (allows building all artifacts for all supported debian-like distros).

/assign @sumitranr

[justaugustus]

/assign @calebamiles @aleksandra-malinowska @hoegaarden

[tpepper]

In general I think I'm ok with this, but I really need to see commit messages.

I'm inferring from the three commits that they do something sensible to me, but even with the context in this PR's conversation I can't validate what I'm reviewing versus the author's intent.

Please amend the three commits with a commit message body as per https://chris.beams.io/posts/git-commit/

[tpepper]

/hold

[justaugustus]

@tpepper -- updated the commit messages!

[spiffxp]

@justaugustus

I think that we should only build for distro versions that are in support.
I'm not sure that we have a policy around that currently, but you're right, AFAIK, this hasn't been discussed widely or documented, so let's consider this the start of that discussion.

As far as documenting a policy or whatever, I'm not sure if this repo or someplace else is more appropriate. As a start, can you leave a comment to this effect next to the distro list, to explain why the default value is what it is?

[tpepper]

Looks good to me, but I want to hold this until after 1.13.7 and 1.14.3 next week, which are loaded with content. But then I'd also like to see if we can even get in more of this type of cleaning in June though ahead of 1.15.

[tpepper]

/retest

[justaugustus]

@tpepper -- SGTM.

@spiffxp -- Added a comment about the distros variable:

release/debian/build.go

Lines 71 to 74 in 66ff86d

	// distros describes the Debian and Ubuntu versions that binaries will be built for.
	// Each distro build definition is currently symlinked to the most recent ubuntu build definition in the repo.
	// Build definitions should be kept up to date across release cycles, removing Debian/Ubuntu versions
	// that are no longer supported from the perspective of the OS distribution maintainers.

// distros describes the Debian and Ubuntu versions that binaries will be built for.
// Each distro build definition is currently symlinked to the most recent ubuntu build definition in the repo.
// Build definitions should be kept up to date across release cycles, removing Debian/Ubuntu versions
// that are no longer supported from the perspective of the OS distribution maintainers.

[sumitranr]

Can you clarify why this is deleted?

[justaugustus]

@sumitranr -- previously, only the kubectl definitions were symlinked. This PR symlinks the full directory, so all binaries are built for each deb distro flavor.

See here: https://github.com/kubernetes/release/pull/720/files#diff-e3f51e32c56fc68e9e81fd19c758c774

[sumitranr]

ah! i should have read your change description more thoroughly. you have already described it there. thanks for clarifying.

[sumitranr]

/lgtm thanks for fixing the script.

[sumitranr]

/lgtm
@tpepper i know you had mentioned that we should hold until 1.13.7 goes out. But i had to do a similar fix to get 1.12.9 out as we weren't able to publish the artifacts for xenial. i believe we might have to submit this even for building those patches

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, sumitranr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [justaugustus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[justaugustus]

@tpepper -- turns out we'll need this merged before the 1.13.7/1.14.3 cuts.

I spoke with @sumitranr and he had to make similar changes to what's in the PR locally to be able to publish 1.12.9.

[tpepper]

/lgtm
@tpepper i know you had mentioned that we should hold until 1.13.7 goes out. But i had to do a similar fix to get 1.12.9 out as we weren't able to publish the artifacts for xenial. i believe we might have to submit this even for building those patches

Ok if we merge this today, could you run (@sumitranr) a test build today or Monday just to triple check the output debs look 100% as expected?

[sumitranr]

/lgtm
@tpepper i know you had mentioned that we should hold until 1.13.7 goes out. But i had to do a similar fix to get 1.12.9 out as we weren't able to publish the artifacts for xenial. i believe we might have to submit this even for building those patches

Ok if we merge this today, could you run (@sumitranr) a test build today or Monday just to triple check the output debs look 100% as expected?

yes. i will double check and do a test build

[tpepper]

/hold cancel