Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create publishing bot issue #676

Merged
merged 7 commits into from
Apr 17, 2019
Merged

Create publishing bot issue #676

merged 7 commits into from
Apr 17, 2019

Conversation

hoegaarden
Copy link
Contributor

When we create a new branch, we can also create an issue for publishing-bot folks, asking them to update the bot's configuration. Also see this convo in slack.

/cc @sttts @nikhita @dims
/assign @kubernetes/bash-firefighters
/area release-eng

gitlib::search_release_issue is not used anymore, after #669.
This function creates an issue on GitHub, notifying some publishing-bot
folks about a new branch.
As part of the release process, we create an issue, notifying the
publishing-bot folks about the new branch and ask them to update the
bot's configuration.
@k8s-ci-robot k8s-ci-robot requested review from dims, nikhita and sttts March 3, 2019 12:47
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 3, 2019
The members to assign to the publishing bot issue are the members of the
github team 'kubernetes/publishing-bot-reviewers'. We query the API to
get all the members and assign to them individually, because GitHub
cannot assign to teams.

However, github can reqeust reviews ("/cc ...") from teams, so we also
do that.
@nikhita
Copy link
Member

nikhita commented Mar 6, 2019

/cc @BenTheElder
for graphql stuff

@k8s-ci-robot k8s-ci-robot requested a review from BenTheElder March 6, 2019 13:55
@BenTheElder
Copy link
Member

BenTheElder commented Mar 6, 2019

First take: this is amazing!
Second take: anago got bigger 😬

EDIT: This looks well implemented FWIW, I just have some broader sneaking concerns about anago 🙈

@hoegaarden
Copy link
Contributor Author

I just have some broader sneaking concerns about anago 🙈

You are not alone on that.

@nikhita
Copy link
Member

nikhita commented Apr 17, 2019

👋 bump

@nikhita
Copy link
Member

nikhita commented Apr 17, 2019

This looks well implemented FWIW, I just have some broader sneaking concerns about anago

@BenTheElder do you think this can be merged or something else needs to be done here?

@BenTheElder
Copy link
Member

/shrug
I won't block it but I think we should really consider writing greenfield automation outside of the anago scripts.

@k8s-ci-robot k8s-ci-robot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Apr 17, 2019
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hoegaarden, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hoegaarden,justaugustus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e2a0d7c into kubernetes:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants