-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create publishing bot issue #676
Create publishing bot issue #676
Conversation
gitlib::search_release_issue is not used anymore, after #669.
This function creates an issue on GitHub, notifying some publishing-bot folks about a new branch.
As part of the release process, we create an issue, notifying the publishing-bot folks about the new branch and ask them to update the bot's configuration.
The members to assign to the publishing bot issue are the members of the github team 'kubernetes/publishing-bot-reviewers'. We query the API to get all the members and assign to them individually, because GitHub cannot assign to teams. However, github can reqeust reviews ("/cc ...") from teams, so we also do that.
/cc @BenTheElder |
First take: this is amazing! EDIT: This looks well implemented FWIW, I just have some broader sneaking concerns about anago 🙈 |
You are not alone on that. |
👋 bump |
@BenTheElder do you think this can be merged or something else needs to be done here? |
/shrug |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hoegaarden, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When we create a new branch, we can also create an issue for publishing-bot folks, asking them to update the bot's configuration. Also see this convo in slack.
/cc @sttts @nikhita @dims
/assign @kubernetes/bash-firefighters
/area release-eng