No longer need to update base.go via rev_version_base(). #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Merged
5 tasks
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Nov 10, 2017
Automatic merge from submit-queue (batch tested with PRs 55265, 54092, 55353, 53733, 55385). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Capture git export-subst strings in version.sh for 'git archive' use. Eliminate the need to update pkg/version/base.go on release branch tagging. This excellent solution brought to you by @ixdy. - [ ] Cherrypick to release-1.8 - [ ] Cherrypick to release-1.7 - [ ] Cherrypick to release-1.6? - [ ] Update kubernetes/release/anago to skip updating base.go files ref kubernetes/release#459 ref #16815 (somewhat related) cc @javier-b-perez
sttts
pushed a commit
to sttts/client-go
that referenced
this pull request
Nov 10, 2017
Automatic merge from submit-queue (batch tested with PRs 55265, 54092, 55353, 53733, 55385). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Capture git export-subst strings in version.sh for 'git archive' use. Eliminate the need to update pkg/version/base.go on release branch tagging. This excellent solution brought to you by @ixdy. - [ ] Cherrypick to release-1.8 - [ ] Cherrypick to release-1.7 - [ ] Cherrypick to release-1.6? - [ ] Update kubernetes/release/anago to skip updating base.go files ref kubernetes/release#459 ref #16815 (somewhat related) cc @javier-b-perez Kubernetes-commit: 4e68d2511ef07428a69a2b6c66efc2b05f4b97dc
david-mcmahon
force-pushed
the
eliminate-version-updates
branch
from
3112075 to
e31cc7a
Compare
|
This is good to go now that all the cherrypicks are in! Anyone? |
|
/lgtm
…On Mon, Nov 13, 2017 at 4:13 PM, David McMahon ***@***.***> wrote:
This is good to go now that all the cherrypicks are in! Anyone?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#459 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEtqgL5tt0My1rQ561m8ambM9np39yBRks5s2NsxgaJpZM4QXRBM>
.
|
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
Oh too slow. :( |
sttts
pushed a commit
to sttts/client-go
that referenced
this pull request
Nov 27, 2017
Automatic merge from submit-queue (batch tested with PRs 55265, 54092, 55353, 53733, 55385). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Capture git export-subst strings in version.sh for 'git archive' use. Eliminate the need to update pkg/version/base.go on release branch tagging. This excellent solution brought to you by @ixdy. - [ ] Cherrypick to release-1.8 - [ ] Cherrypick to release-1.7 - [ ] Cherrypick to release-1.6? - [ ] Update kubernetes/release/anago to skip updating base.go files ref kubernetes/release#459 ref #16815 (somewhat related) cc @javier-b-perez Kubernetes-commit: 4e68d2511ef07428a69a2b6c66efc2b05f4b97dc
sttts
pushed a commit
to sttts/client-go
that referenced
this pull request
Nov 28, 2017
Automatic merge from submit-queue (batch tested with PRs 55265, 54092, 55353, 53733, 55385). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Capture git export-subst strings in version.sh for 'git archive' use. Eliminate the need to update pkg/version/base.go on release branch tagging. This excellent solution brought to you by @ixdy. - [ ] Cherrypick to release-1.8 - [ ] Cherrypick to release-1.7 - [ ] Cherrypick to release-1.6? - [ ] Update kubernetes/release/anago to skip updating base.go files ref kubernetes/release#459 ref #16815 (somewhat related) cc @javier-b-perez Kubernetes-commit: 4e68d2511ef07428a69a2b6c66efc2b05f4b97dc
sttts
pushed a commit
to sttts/client-go
that referenced
this pull request
Nov 28, 2017
Automatic merge from submit-queue (batch tested with PRs 55265, 54092, 55353, 53733, 55385). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Capture git export-subst strings in version.sh for 'git archive' use. Eliminate the need to update pkg/version/base.go on release branch tagging. This excellent solution brought to you by @ixdy. - [ ] Cherrypick to release-1.8 - [ ] Cherrypick to release-1.7 - [ ] Cherrypick to release-1.6? - [ ] Update kubernetes/release/anago to skip updating base.go files ref kubernetes/release#459 ref #16815 (somewhat related) cc @javier-b-perez Kubernetes-commit: 4e68d2511ef07428a69a2b6c66efc2b05f4b97dc
sttts
pushed a commit
to sttts/client-go
that referenced
this pull request
Nov 28, 2017
Automatic merge from submit-queue (batch tested with PRs 55265, 54092, 55353, 53733, 55385). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Capture git export-subst strings in version.sh for 'git archive' use. Eliminate the need to update pkg/version/base.go on release branch tagging. This excellent solution brought to you by @ixdy. - [ ] Cherrypick to release-1.8 - [ ] Cherrypick to release-1.7 - [ ] Cherrypick to release-1.6? - [ ] Update kubernetes/release/anago to skip updating base.go files ref kubernetes/release#459 ref #16815 (somewhat related) cc @javier-b-perez Kubernetes-commit: 4e68d2511ef07428a69a2b6c66efc2b05f4b97dc
sttts
pushed a commit
to sttts/client-go
that referenced
this pull request
Nov 28, 2017
Automatic merge from submit-queue (batch tested with PRs 55265, 54092, 55353, 53733, 55385). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Capture git export-subst strings in version.sh for 'git archive' use. Eliminate the need to update pkg/version/base.go on release branch tagging. This excellent solution brought to you by @ixdy. - [ ] Cherrypick to release-1.8 - [ ] Cherrypick to release-1.7 - [ ] Cherrypick to release-1.6? - [ ] Update kubernetes/release/anago to skip updating base.go files ref kubernetes/release#459 ref #16815 (somewhat related) cc @javier-b-perez Kubernetes-commit: 4e68d2511ef07428a69a2b6c66efc2b05f4b97dc
k8s-publishing-bot
pushed a commit
to k8s-publishing-bot/client-go
that referenced
this pull request
Nov 29, 2017
Automatic merge from submit-queue (batch tested with PRs 55265, 54092, 55353, 53733, 55385). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Capture git export-subst strings in version.sh for 'git archive' use. Eliminate the need to update pkg/version/base.go on release branch tagging. This excellent solution brought to you by @ixdy. - [ ] Cherrypick to release-1.8 - [ ] Cherrypick to release-1.7 - [ ] Cherrypick to release-1.6? - [ ] Update kubernetes/release/anago to skip updating base.go files ref kubernetes/release#459 ref #16815 (somewhat related) cc @javier-b-perez Kubernetes-commit: 4e68d2511ef07428a69a2b6c66efc2b05f4b97dc
k8s-publishing-bot
pushed a commit
to k8s-publishing-bot/client-go
that referenced
this pull request
Dec 7, 2017
Automatic merge from submit-queue (batch tested with PRs 55265, 54092, 55353, 53733, 55385). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Capture git export-subst strings in version.sh for 'git archive' use. Eliminate the need to update pkg/version/base.go on release branch tagging. This excellent solution brought to you by @ixdy. - [ ] Cherrypick to release-1.8 - [ ] Cherrypick to release-1.7 - [ ] Cherrypick to release-1.6? - [ ] Update kubernetes/release/anago to skip updating base.go files ref kubernetes/release#459 ref #16815 (somewhat related) cc @javier-b-perez Kubernetes-commit: 4e68d2511ef07428a69a2b6c66efc2b05f4b97dc
marpaia
pushed a commit
to marpaia/release
that referenced
this pull request
Feb 21, 2019
Adding 1.14 Shadows For Release Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref kubernetes/kubernetes#55353.
Do not submit until kubernetes/kubernetes#55353 is submitted and cherrypicked to all active release branches.