Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add job to test packages with rpmlint #3589

Merged
merged 2 commits into from
Jun 27, 2024
Merged

add job to test packages with rpmlint #3589

merged 2 commits into from
Jun 27, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Apr 27, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • add job to test packages with rpmlint

Which issue(s) this PR fixes:

Fixes #3166

Special notes for your reviewer:

Does this PR introduce a user-facing change?

add job to test packages with rpmlint

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 27, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 27, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 27, 2024
@saschagrunert
Copy link
Member

CI is not happy unfortunately:

level=fatal msg="running krel obs: constructing package definition: getting metadata for \"cri-tools\": parsing metadata for cri-tools: parsing package version : Version string empty"

@cpanato
Copy link
Member Author

cpanato commented May 7, 2024

cc @xmudrii

@cpanato
Copy link
Member Author

cpanato commented May 28, 2024

@xmudrii, can you please look at this PR when you have some time? Thanks!

@xmudrii
Copy link
Member

xmudrii commented May 28, 2024

@cpanato It's on my TODO list, will try to get back to you as soon as possible. :)

xmudrii
xmudrii reviewed May 28, 2024
View reviewed changes
hack/verify-package-specs.sh Outdated Show resolved Hide resolved
hack/verify-package-specs.sh Outdated Show resolved Hide resolved
hack/verify-package-specs.sh Show resolved Hide resolved
@xmudrii xmudrii mentioned this pull request May 31, 2024
Merged
@cpanato
Copy link
Member Author

cpanato commented Jun 26, 2024

@xmudrii PTAL

@cpanato cpanato requested a review from xmudrii June 26, 2024 16:18
@cpanato
Copy link
Member Author

cpanato commented Jun 26, 2024

/hold to update based feedback

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2024
@cpanato
Copy link
Member Author

cpanato commented Jun 26, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2024
@cpanato cpanato requested a review from xmudrii June 26, 2024 16:49
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7a79089 into kubernetes:master Jun 27, 2024
11 checks passed
@cpanato cpanato deleted the GH-3166 branch June 27, 2024 07:38
xmudrii
xmudrii reviewed Jun 27, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Belated LGTM, thank you!
/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@jimangel jimangel Awaiting requested review from jimangel

@salaxander salaxander Awaiting requested review from salaxander

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add presubmit job to run rpmlint on package specs
4 participants
@cpanato @saschagrunert @xmudrii @k8s-ci-robot