-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distroless-iptables: fix grep
command
#3237
Conversation
The issue was that libaries from /usr/lib get symlinked from /lib, which is just a symlink to /usr/lib in debian 12. To avoid that, we now always refer to /usr/lib. To avoid wrong glibc versions we also have to use distroless/base-debian12. Bumped the version of the image to v0.3.1. Signed-off-by: Sascha Grunert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Inherited from: - kubernetes/release#3235 - kubernetes/release#3237 As well as bumping the haproxy version. Tested via: ``` docker buildx build --platform=linux/amd64,linux/arm64 --progress=auto -t gcr.io/k8s-staging-kind/haproxy:v20230905-7dc7aad7 --pull --build-arg GO_VERSION=1.20.4 . ``` Signed-off-by: Sascha Grunert <[email protected]>
What type of PR is this?
/kind bug
What this PR does / why we need it:
The issue was that libaries from /usr/lib get symlinked from /lib, which is just a symlink to /usr/lib in debian 12. To avoid that, we now always refer to /usr/lib. To avoid wrong glibc versions we also have to use distroless/base-debian12.
Bumped the version of the image to v0.3.1.
Which issue(s) this PR fixes:
Refers to #3128
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?