Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update publishing-bot issue repo to k/sig-release #3198

Merged
merged 1 commit into from
Aug 16, 2023
Merged

update publishing-bot issue repo to k/sig-release #3198

merged 1 commit into from
Aug 16, 2023

Conversation

akhilerm
Copy link
Member

@akhilerm akhilerm commented Aug 8, 2023 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Currently the issue for updating the branch rules for publishing-bot for a new release are created in k8s-release-robot/sig-release. Update this to create new issues in k/sig-release.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

publishing-bot issue will now be created in kubernetes/sig-release instead of k8s-release-robot/sig-release

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject labels Aug 8, 2023
@k8s-ci-robot k8s-ci-robot requested review from jimangel and jrsapi August 8, 2023 10:33
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 8, 2023
@akhilerm
Copy link
Member Author

akhilerm commented Aug 8, 2023

/cc @palnabarun

@k8s-ci-robot k8s-ci-robot requested a review from palnabarun August 8, 2023 10:34
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 8, 2023
palnabarun
palnabarun reviewed Aug 16, 2023
View reviewed changes
pkg/release/release.go Outdated
Comment on lines 133 to 134
PubBotRepoOrg = "k8s-release-robot"
PubBotRepoName = "sig-release"
PubBotRepoOrg = "kubernetes"
PubBotRepoName = "kubernetes"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am debating in my mind between possible repositories where this issue should be created. It's the responsibility of the Release Manager to create the rule mappings. Considering that and also the fact that this issue is to signal people to create the rule mapping, the best place to create the issue should be kubernetes/sig-release and assign/cc @kubernetes/release-managers in the issue body.

WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. I am not completely aware of the release process. But taking a quick look at the issues in the repository it seems like k/sig-release has issues created related to release creation. So that will be more suitable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 16, 2023
@akhilerm
Copy link
Member Author

/retitle update publishing-bot issue repo to k/sig-release

@k8s-ci-robot k8s-ci-robot changed the title update publishing-bot issue repo to k/k update publishing-bot issue repo to k/sig-release Aug 16, 2023
@akhilerm
update publishing bot issue repo to k/sig-release
176088c 
- update the repository in which issue is created for updating the publishing-bot
rules for a release from k8s-release-robot/sig-release to kubernetes/sig-release.
- assign the issue to kubernetes/release-managers github team

Signed-off-by: Akhil Mohan <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 16, 2023
Verolop
Verolop reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@Verolop Verolop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhilerm, Verolop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit b446fbb into kubernetes:master Aug 16, 2023
@akhilerm akhilerm deleted the update-issue-repo branch August 16, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palnabarun palnabarun palnabarun left review comments

@Verolop Verolop Verolop left review comments

@jimangel jimangel Awaiting requested review from jimangel

@jrsapi jrsapi Awaiting requested review from jrsapi

Assignees

@Verolop Verolop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akhilerm @k8s-ci-robot @Verolop @palnabarun