-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add osc to k8s-cloud-builder image #3084
Conversation
Signed-off-by: Marko Mudrinić <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking question: it is OK to install the latest available or should we pin to a specific version?
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Latest is okay because we use managed OBS instance which is frequently updated. The commands that we use shouldn’t be changed frequently or at all. |
Let’s iterate on this and we can always revert if needed |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds
osc
to k8s-cloud-builder image.osc
is CLI for OpenBuildService (OBS) and we're going to use it for building and publishing packages.osc
is available as a package in Debian repositories out of the box.The list of packages that are added with the
osc
package:Special notes for your reviewer:
I have some concerns regarding the number of dependencies that are installed:
I decided to go with k8s-cloud-bulider because that's what we use in stage and release for krel. We'll extend stage and release steps with OBS workflow, so I wanted to keep the same image. Alternative is to create a new image or repurpose the kubepkg image, but I'm opening this PR to collect ideas and feedback.
Does this PR introduce a user-facing change?
/assign @saschagrunert @cpanato @jeremyrickard
cc @kubernetes/release-engineering
/hold
for discussion